postgresql.git/src/bin/pg_basebackup/pg_receivewal.c, branch master

Fix -Wshadow=local warnings

2026-09-08T06:49:30Z

This fixes issues with the same variable name being used in the same function for two different variables. (In some cases, one of the uses is a function argument.) The fix is in most cases to rename one or both of them. The individual choice depends on conventions in the surrounding code. Often, making both variable names more specific is the best choice. In a few cases, the fix is to move one of the variables to a lower scope, so that it no longer conflicts with the other. Since these are all local-variable conflicts, the changes in different files in this patch are independent of each other. These issues correspond to the gcc warning option -Wshadow=local, which is not currently used but could be activated after this. Reviewed-by: Peter Geoghegan Reviewed-by: Chao Li Discussion: https://www.postgresql.org/message-id/flat/84b6f128-91f5-480e-8a9e-7d0e8f538cea%40eisentraut.org

Add common LSN parser for user-supplied locations

2026-08-12T08:03:46Z

pg_waldump (--start/--end), pg_recvlogical (--startpos/--endpos), and pg_receivewal (--endpos) parsed user-supplied WAL locations with sscanf("%X/%08X"). That accepts several forms rejected by pg_lsn input and can proceed with a different location than the user specified: overlong components, trailing characters, leading whitespace, signs, and 0x prefixes. Add pg_parse_lsn() to src/common and use it for those command-line options. The helper accepts the pg_lsn text syntax only: one to eight hexadecimal digits, a slash, one to eight hexadecimal digits, and no trailing characters. Each frontend tool keeps its existing error message. Use the same helper from pg_lsn_in_safe(), leaving only backend-specific soft error reporting there. This keeps frontend command-line validation and backend pg_lsn input tied to one parser. Bug: #19598 Reported-by: Michael Malis Author: Zexin Li Reviewed-by: Ayush Tiwari Reviewed-by: Fujii Masao Discussion: https://postgr.es/m/19598-aa67c8f4331611b4@postgresql.org

Clean up read() return type

2026-07-15T07:43:03Z

and analogously for pg_pread() and FileRead() Be sure to store the return value in a variable of type ssize_t, not int. Also make the error messages for short reads consistent. They should always be like "read %zd of %zu". Appearance of other placeholders indicates the types are probably wrong (although in some cases some casts are added to make macros have the right type and keep the strings consistent, and it some cases it's left as "%zu of %zu", which is close enough). In several cases, the input length is derived from struct stat st_size, which has type off_t, which is neither size_t nor ssize_t. To keep the type handling clearer, this introduces intermediate variables in these cases. In SendTimeLineHistory() in walsender.c, we need to adjust the logic a bit to over underflow wrap if we end up reading more from the file than expected. This is believed to be a theoretical problem only. Alternatively, we could treat this as an error. Note that the previous code would have processed the extra data but only up to a full block, which seems wrong in any case. Reviewed-by: Heikki Linnakangas Discussion: https://www.postgresql.org/message-id/flat/f9aab072-0078-49e4-ab93-3b08086a4406@eisentraut.org

Fix variety of typos and grammar mistakes

2026-02-24T04:26:37Z

This commit includes a batch of fixes for various minor typos and grammar mistakes, that have been proposed to the hackers mailing list since the beginning of January. Similar batches are planned on a bi-monthly basis depending on the amount received, with the next one for the end of April.

Update copyright for 2026

2026-01-01T18:24:10Z

Backpatch-through: 14

Use XLogRecPtrIsValid() in various places

2025-11-06T19:33:57Z

Now that commit 06edbed47862 has introduced XLogRecPtrIsValid(), we can use that instead of: - XLogRecPtrIsInvalid() - direct comparisons with InvalidXLogRecPtr - direct comparisons with literal 0 This makes the code more consistent. Author: Bertrand Drouvot Discussion: https://postgr.es/m/aQB7EvGqrbZXrMlg@ip-10-97-1-34.eu-west-3.compute.internal

Standardize LSN formatting by zero padding

2025-07-07T11:57:43Z

This commit standardizes the output format for LSNs to ensure consistent representation across various tools and messages. Previously, LSNs were inconsistently printed as `%X/%X` in some contexts, while others used zero-padding. This often led to confusion when comparing. To address this, the LSN format is now uniformly set to `%X/%08X`, ensuring the lower 32-bit part is always zero-padded to eight hexadecimal digits. Author: Japin Li Reviewed-by: Masahiko Sawada Reviewed-by: Álvaro Herrera Discussion: https://postgr.es/m/ME0P300MB0445CA53CA0E4B8C1879AF84B641A@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM

pg_recvlogical: Add --failover option.

2025-04-04T17:39:57Z

This new option instructs pg_recvlogical to create the logical replication slot with the failover option enabled. It can be used in conjunction with the --create-slot option. Author: Hayato Kuroda Reviewed-by: Michael Banck Reviewed-by: Masahiko Sawada Discussion: https://postgr.es/m/OSCPR01MB14966C54097FC83AF19F3516BF5AC2@OSCPR01MB14966.jpnprd01.prod.outlook.com

Remove various unnecessary (char *) casts

2025-02-20T18:49:27Z

Remove a number of (char *) casts that are unnecessary. Or in some cases, rewrite the code to make the purpose of the cast clearer. Reviewed-by: Dagfinn Ilmari Mannsåker Discussion: https://www.postgresql.org/message-id/flat/fd1fcedb-3492-4fc8-9e3e-74b97f2db6c7%40eisentraut.org

2025-01-01T16:21:55Z

Backpatch-through: 13