Prevent pausable composition from dispatching redundant remembers

If a pausable composition is paused the composition, the state may
have changed to cause a remembered disposable effect to be replaced
before `apply()` is called. This can cause the disposable object
being remembered and forgotten in the same apply.

This change prevents the same apply from both remembering and
forgetting the same instance in the same apply.

This change also will ensure that paused compositions are no
longer recomposed outside of calls to resume. This change makes
it dangerous to call apply without first checking isComplete as
noted in the change method documentation.

Fixes: 404645679
Fixes: 407931790
Test: ./gradlew :compose:r:r:i-t:cC
Relnote: """Fix dispatching of remember observers in pausable
composition to avoid dispatching remembered/forgotten in the
same apply"""

Change-Id: I570b2436b95c7f8fb88a6f9824dbb9b8bccbc0fa
5 files changed
tree: 8319cadaf41a4de85109c239a7734fa90b83bf39
  1. .github/
  2. .idea/
  3. activity/
  4. annotation/
  5. appcompat/
  6. appfunctions/
  7. appintegration/
  8. appsearch/
  9. arch/
  10. asynclayoutinflater/
  11. autofill/
  12. benchmark/
  13. binarycompatibilityvalidator/
  14. biometric/
  15. browser/
  16. buildSrc/
  17. buildSrc-tests/
  18. busytown/
  19. camera/
  20. car/
  21. cardview/
  22. collection/
  23. compose/
  24. concurrent/
  25. constraintlayout/
  26. coordinatorlayout/
  27. core/
  28. credentials/
  29. cursoradapter/
  30. customview/
  31. datastore/
  32. development/
  33. docs/
  34. docs-public/
  35. docs-tip-of-tree/
  36. documentfile/
  37. draganddrop/
  38. drawerlayout/
  39. dynamicanimation/
  40. emoji/
  41. emoji2/
  42. enterprise/
  43. exifinterface/
  44. external/
  45. fragment/
  46. glance/
  47. gradle/
  48. graphics/
  49. gridlayout/
  50. health/
  51. heifwriter/
  52. hilt/
  53. ink/
  54. input/
  55. inspection/
  56. interpolator/
  57. javascriptengine/
  58. kruth/
  59. leanback/
  60. lifecycle/
  61. lint/
  62. lint-checks/
  63. loader/
  64. media/
  65. mediarouter/
  66. metrics/
  67. navigation/
  68. navigation3/
  69. paging/
  70. palette/
  71. pdf/
  72. percentlayout/
  73. performance/
  74. placeholder/
  75. placeholder-tests/
  76. playground-common/
  77. playground-projects/
  78. preference/
  79. print/
  80. privacysandbox/
  81. profileinstaller/
  82. recommendation/
  83. recyclerview/
  84. remotecallback/
  85. resourceinspection/
  86. room/
  87. safeparcel/
  88. samples/
  89. savedstate/
  90. security/
  91. sharetarget/
  92. slidingpanelayout/
  93. sqlite/
  94. stableaidl/
  95. startup/
  96. swiperefreshlayout/
  97. test/
  98. testutils/
  99. text/
  100. tracing/
  101. transition/
  102. tv/
  103. tvprovider/
  104. vectordrawable/
  105. versionedparcelable/
  106. viewpager/
  107. viewpager2/
  108. wear/
  109. webkit/
  110. window/
  111. work/
  112. xr/
  113. .gitignore
  114. build.gradle
  115. cleanBuild.sh
  116. code-review.md
  117. CONTRIBUTING.md
  118. gradle.properties
  119. gradlew
  120. libraryversions.toml
  121. license-baseline.txt
  122. LICENSE.txt
  123. OWNERS
  124. PREUPLOAD.cfg
  125. README.md
  126. settings.gradle
  127. studiow
  128. TEXT_OWNERS
README.md

Android Jetpack

Revved up by Develocity

Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.

Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.

Our official AARs and JARs binaries are distributed through Google Maven.

You can learn more about using it from Android Jetpack landing page.

Contribution Guide

For contributions via GitHub, see the GitHub Contribution Guide.

Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:

Code Review Etiquette

When contributing to Jetpack, follow the code review etiquette.

Accepted Types of Contributions

  • Bug fixes - needs a corresponding bug report in the Android Issue Tracker
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests
  • New features to existing libraries if the feature request bug has been approved by an AndroidX team member.

We are not currently accepting new modules.

Checking Out the Code

Head over to the onboarding docs to learn more about getting set up and the development workflow!

Continuous integration

Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.

Password and Contributor Agreement before making a change

Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:

Generate a HTTPS password: https://android-review.googlesource.com/new-password

Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing or check the OWNERS file in the project's directory)

Handling binary dependencies

AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.