Google Git
Sign in
android / platform / frameworks / support / 0cb41981b356abc62acab56634bda240d5809064
commit0cb41981b356abc62acab56634bda240d5809064[log] [tgz]
authorDaniel Santiago Rivera <[email protected]>Wed Oct 12 13:26:54 2022 -0400
committerDaniel Santiago Rivera <[email protected]>Mon Oct 17 21:38:21 2022 -0400
treed3a419bfe52959faf37d35c06c76fd6108229bfc
parentdd774999930afba89226586051679f1e622b6649 [diff]
Migrate QueryParameterAdapter implementations to XPoet

The migrated adapters are:
 * BasicQueryParameterAdapter
 * ArrayQueryParameterAdapter
 * CollectionQueryParameterAdapter

A notable change is that nullability of the array and collection parameters have to be considered. Instead of prohibit this CL simply accepts them by binding a null arg when the param is null, essentially tackling b/72246856. This change affects all backends (javac, kapt and ksp) and Java code generation too, passing a null collection as a query param will no longer cause a crash.

Also fixed a bug in KspArrayType.asTypeName() where the KTypeName didn't had right nullability, fixed it by using the KsTypeKotlinPoetExt (it was a missed migration).

New XPoet API:
 * XCodeBlock.ofTernaryIf() - For generating inline if expressions with Java's ternary operator and Kotlin if/else.

Bug: 72246856
Bug: 127483380
Test: NullableCollectionQueryParamTest + KotlinCodeGenTest
Change-Id: I5e5b6a73733f2bbc8d111cdfa724720757ab38c5
21 files changed
tree: d3a419bfe52959faf37d35c06c76fd6108229bfc
  1. .github/
  2. .idea/
  3. activity/
  4. ads/
  5. annotation/
  6. appcompat/
  7. appsearch/
  8. arch/
  9. asynclayoutinflater/
  10. autofill/
  11. benchmark/
  12. biometric/
  13. bluetooth/
  14. browser/
  15. buildSrc/
  16. buildSrc-tests/
  17. busytown/
  18. camera/
  19. car/
  20. cardview/
  21. collection/
  22. compose/
  23. concurrent/
  24. constraintlayout/
  25. contentpager/
  26. coordinatorlayout/
  27. core/
  28. credentials/
  29. cursoradapter/
  30. customview/
  31. datastore/
  32. development/
  33. docs/
  34. docs-kmp/
  35. docs-public/
  36. docs-tip-of-tree/
  37. documentfile/
  38. draganddrop/
  39. drawerlayout/
  40. dynamicanimation/
  41. emoji/
  42. emoji2/
  43. enterprise/
  44. exifinterface/
  45. external/
  46. fragment/
  47. frameworks/
  48. glance/
  49. gradle/
  50. graphics/
  51. gridlayout/
  52. health/
  53. heifwriter/
  54. hilt/
  55. input/
  56. inspection/
  57. interpolator/
  58. javascriptengine/
  59. leanback/
  60. lifecycle/
  61. lint-checks/
  62. loader/
  63. media/
  64. media2/
  65. mediarouter/
  66. metrics/
  67. navigation/
  68. paging/
  69. palette/
  70. percentlayout/
  71. placeholder/
  72. placeholder-tests/
  73. playground-common/
  74. preference/
  75. print/
  76. privacysandbox/
  77. profileinstaller/
  78. recommendation/
  79. recyclerview/
  80. remotecallback/
  81. resourceinspection/
  82. room/
  83. samples/
  84. savedstate/
  85. security/
  86. sharetarget/
  87. slice/
  88. slidingpanelayout/
  89. sqlite/
  90. startup/
  91. swiperefreshlayout/
  92. test/
  93. testutils/
  94. text/
  95. tracing/
  96. transition/
  97. tv/
  98. tvprovider/
  99. vectordrawable/
  100. versionedparcelable/
  101. viewpager/
  102. viewpager2/
  103. wear/
  104. webkit/
  105. window/
  106. work/
  107. .gitignore
  108. .mailmap
  109. build.gradle
  110. cleanBuild.sh
  111. code-review.md
  112. CONTRIBUTING.md
  113. gradle.properties
  114. gradlew
  115. libraryversions.toml
  116. LICENSE.txt
  117. OWNERS
  118. PREUPLOAD.cfg
  119. README.md
  120. settings.gradle
  121. studiow
  122. TEXT_OWNERS
README.md

Android Jetpack

Revved up by Gradle Enterprise

Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.

Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.

Our official AARs and JARs binaries are distributed through Google Maven.

You can learn more about using it from Android Jetpack landing page.

Contribution Guide

For contributions via GitHub, see the GitHub Contribution Guide.

Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:

Code Review Etiquette

When contributing to Jetpack, follow the code review etiquette.

Accepted Types of Contributions

  • Bug fixes - needs a corresponding bug report in the Android Issue Tracker
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests
  • New features to existing libraries if the feature request bug has been approved by an AndroidX team member.

We are not currently accepting new modules.

Checking Out the Code

Head over to the onboarding docs to learn more about getting set up and the development workflow!

Continuous integration

Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.

Password and Contributor Agreement before making a change

Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:

Generate a HTTPS password: https://android-review.googlesource.com/new-password

Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing or check the OWNERS file in the project's directory)

Handling binary dependencies

AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), jcenter(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.