| commit | fd6e070c2cde0520fc711012bd04ed3aefc718d2 | [log] [tgz] |
|---|---|---|
| author | Mady Mellor <[email protected]> | Mon Jul 02 18:33:47 2018 -0700 |
| committer | Mady Mellor <[email protected]> | Tue Jul 03 13:31:20 2018 -0700 |
| tree | 6010c8055bb85de91affacc68ab4062461775b09 | |
| parent | 95fb8a689fdcbf4ea001667c2fe4c1a0522259e0 [diff] |
Show a spinner if a slice is loading when action is tapped
Behaviour:
* Action clicks -> show a spinner in place of the action
* Content clicks -> show a spinner in the header
* Spinners are tinted using colorControlHighlight, tested in
light / dark theme
* Loading state persists across mode and layout changes
* Made RowView a bit better at not clobbering all its stuff when any
update happens (whether slice or style / layout changes); decoupled:
- changes in header actions / end items
- changes in subtitle / last updated text
- removed some duplicated logic by calling through to SliceView
for row clicks
* Fixes an issue where end container showing actions / images wasn’t
‘gone’ when not showing anything
* Fixes an issue where shortcuts could have null actions
Fixes: 110224343
Test: ./gradlew slice-view:connectedCheck + manual
manual: CP ag/4462524 for delay hack in loading the live slice and then:
1) Ride slice, set serialized
- tap on header, tap on home button, tap on work row
=> each should show a spinner
- switch from large -> small and back; all spinners should
remain if the row is visible
- eventually updates with live slice and spinners are cleared
2) Contact slice, set serialized
- tap on bottom area, this activates primary action on this
slice so a spinner should show in the header row
- tap on header actions
=> each should show a spinner
- switch from large -> small -> shortcut -> large; spinners
should remain in small / large
- eventually updates with live slice and spinners are cleared
3) Wifi slice, set serialized
- tap on header, toggle, and a list item
=> each should show a spinner
- switch from large -> small; all spinners should remain
- disable scrolling; tap on ‘see more’ button; note spinner
- eventually updates with live slice and spinners are cleared
Change-Id: I9b6fcaa97e8cce585380802a82ed493b7253b5c9
We are not currently accepting new modules, features, or behavior changes.
NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.
Follow the “Downloading the Source” guide to install and set up repo tool, but instead of running the listed repo commands to initialize the repository, run the folowing:
repo init -u https://android.googlesource.com/platform/manifest -b ub-supportlib-master
Now your repository is set to pull only what you need for building and running support library. Download the code (and grab a coffee while we pull down 7GB):
repo sync -j8 -c
You will use this command to sync your checkout in the future - it’s similar to git fetch
Open path/to/checkout/frameworks/support/ in Android Studio. Now you're ready edit, run, and test!
If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.
If you see any warnings (red underlines) run Build > Clean Project.
You can do most of your work from Android Studio, however you can also build the full support library from command line:
cd path/to/checkout/frameworks/support/ ./gradlew createArchive
If you intend to repeatedly make changes to Support Library and to wish to see the results in your app, and you don't want to have to repeatedly build them as separate Gradle projects, you can configure your app build to build Support Library too
Run FooBarTestRun android.support.foobarSupport library has a set of Android applications that exercise support library code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.
These applications are named support-*-demos (e.g. support-4v-demos or support-leanback-demos. You can run them by clicking Run > Run ... and choosing the desired application.
cd path/to/checkout/frameworks/support/ repo start my_branch_name . (make needed modifications) git commit -a repo upload --current-branch .
If you see the following prompt, choose always:
Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?