[#118346] [Ruby master Bug#20586] Some filesystem calls in dir.c are missing error handling and can return incorrect results if interrupted — "ivoanjo (Ivo Anjo) via ruby-core" <ruby-core@...>
Issue #20586 has been reported by ivoanjo (Ivo Anjo).
13 messages
2024/06/19
[ruby-core:118248] [Ruby master Bug#20524] mswin and gmp
From:
"nagachika (Tomoyuki Chikanaga) via ruby-core" <ruby-core@...>
Date:
2024-06-08 00:32:36 UTC
List:
ruby-core #118248
Issue #20524 has been updated by nagachika (Tomoyuki Chikanaga). Backport changed from 3.1: REQUIRED, 3.2: REQUIRED, 3.3: REQUIRED to 3.1: W= ONTFIX, 3.2: WONTFIX, 3.3: REQUIRED I think this is a kind of new feature of ruby build system. I won't backpor= t it to 3.2 branch. It's up to kokubun-san for 3.3 branch. ---------------------------------------- Bug #20524: mswin and gmp https://bugs.ruby-lang.org/issues/20524#change-108746 * Author: MSP-Greg (Greg L) * Status: Closed * Backport: 3.1: WONTFIX, 3.2: WONTFIX, 3.3: REQUIRED ---------------------------------------- Currently, the `vcpkg.json` file exists, and it can be used to specify what= MSFT/vcpkg packages to install, and also a repo commit, which will determi= ne the what package versions are used. The file lists the gmp package. 1. To use the gmp package in mswin, `win32/configure.bat` shows an option o= f `--with-gmp`. This option is not used in the `windows.yml` workflow file= , nor is it mentioned in `doc/windows.md`. 2. When using the option, the build fails when compiling `bignum.c`, as it = can=E2=80=99t find `gmp.h`. It appears the vcpkg include folder is not bei= ng passed to `cl`? So, it seems a few things are amiss. `gmp` was added a long time ago. Wit= h current mswin builds, will `gmp` improve `Bignum`=E2=80=99s performance? = Is that unknown? If there are benchmarks to determine this, I could certa= inly run them=E2=80=A6 --=20 https://bugs.ruby-lang.org/