[#47787] Ruby Parallelism — Miguel Palhas <mpalhas@...>
Greetings
4 messages
2012/10/01
[#47790] [ruby-trunk - Bug #7097][Open] Thread locals don't work inside Enumerator — "tenderlovemaking (Aaron Patterson)" <aaron@...>
32 messages
2012/10/01
[#47791] [ruby-trunk - Bug #7097][Assigned] Thread locals don't work inside Enumerator
— "kosaki (Motohiro KOSAKI)" <kosaki.motohiro@...>
2012/10/01
[#47792] Re: [ruby-trunk - Bug #7097][Assigned] Thread locals don't work inside Enumerator
— Aaron Patterson <tenderlove@...>
2012/10/01
On Tue, Oct 02, 2012 at 03:05:17AM +0900, kosaki (Motohiro KOSAKI) wrote:
[#47798] Re: [ruby-trunk - Bug #7097][Assigned] Thread locals don't work inside Enumerator
— SASADA Koichi <ko1@...>
2012/10/01
(2012/10/02 3:12), Aaron Patterson wrote:
[#47800] Re: [ruby-trunk - Bug #7097][Assigned] Thread locals don't work inside Enumerator
— SASADA Koichi <ko1@...>
2012/10/01
(2012/10/02 8:22), SASADA Koichi wrote:
[#47802] Re: [ruby-trunk - Bug #7097][Assigned] Thread locals don't work inside Enumerator
— Aaron Patterson <tenderlove@...>
2012/10/02
On Tue, Oct 02, 2012 at 08:32:51AM +0900, SASADA Koichi wrote:
[#47807] Re: [ruby-trunk - Bug #7097][Assigned] Thread locals don't work inside Enumerator
— KOSAKI Motohiro <kosaki.motohiro@...>
2012/10/02
>> For example:
[#48291] [ruby-trunk - Bug #7097] Thread locals don't work inside Enumerator
— "tenderlovemaking (Aaron Patterson)" <aaron@...>
2012/10/25
[#48299] Re: [ruby-trunk - Bug #7097] Thread locals don't work inside Enumerator
— SASADA Koichi <ko1@...>
2012/10/26
I don't have any objection.
[#48300] Re: [ruby-trunk - Bug #7097] Thread locals don't work inside Enumerator
— Aaron Patterson <tenderlove@...>
2012/10/26
On Fri, Oct 26, 2012 at 02:40:53PM +0900, SASADA Koichi wrote:
[#47832] [ruby-trunk - Feature #7106][Open] FileUtils.touch should allow touching the symlink itself rather than the file the link points to — "cirrusthinking (Alessandro Diaferia)" <alessandro@...>
18 messages
2012/10/04
[#47841] [ruby-trunk - Bug #7109][Open] File.utime doesn't set nanoseconds — "bkabrda (Bohuslav Kabrda)" <bkabrda@...>
6 messages
2012/10/05
[#47842] Re: [ruby-trunk - Bug #7109][Open] File.utime doesn't set nanoseconds
— Tanaka Akira <akr@...>
2012/10/05
2012/10/5 bkabrda (Bohuslav Kabrda) <[email protected]>:
[#47847] [ruby-trunk - Bug #7110][Open] CGI: Add support for HTML5 <header> tag — "stomar (Marcus Stollsteimer)" <redmine@...>
16 messages
2012/10/05
[#47880] [ruby-trunk - Bug #7134][Open] Signal handling bug in Mac OS X — "auastro (Andy Kitchen)" <kitchen.andy+rubybug@...>
17 messages
2012/10/10
[#48918] [ruby-trunk - Bug #7134][Assigned] Signal handling bug in Mac OS X
— "mame (Yusuke Endoh)" <mame@...>
2012/11/05
[#47881] [ruby-trunk - Bug #7135][Open] GC bug in Ruby 1.9.3-p194? — "alexdowad (Alex Dowad)" <alexinbeijing@...>
21 messages
2012/10/10
[#47887] [ruby-trunk - Bug #7137][Open] Date.parse overly lenient when attempting to parse Monday? — "garysweaver (Gary Weaver)" <garysweaver@...>
12 messages
2012/10/10
[#47927] new ruby 1.9.3 maintainer — "U.Nakamura" <usa@...>
Hello everyone of the Ruby development community
6 messages
2012/10/12
[#47930] [ruby-trunk - Feature #7148][Open] Improved Tempfile w/o DelegateClass — "Glass_saga (Masaki Matsushita)" <glass.saga@...>
14 messages
2012/10/12
[#47963] [ruby-trunk - Bug #7154][Open] For whatever reason \s doesn't match \u00a0. — "t0d0r (Todor Dragnev)" <todor.dragnev@...>
5 messages
2012/10/13
[#47970] [ruby-trunk - Bug #7158][Open] require is slow in its bookkeeping; can make Rails startup 2.2x faster — "gregprice (Greg Price)" <price@...>
30 messages
2012/10/14
[#48504] [ruby-trunk - Bug #7158] require is slow in its bookkeeping; can make Rails startup 2.2x faster
— "h.shirosaki (Hiroshi Shirosaki)" <h.shirosaki@...>
2012/10/27
[#48505] Re: [ruby-trunk - Bug #7158] require is slow in its bookkeeping; can make Rails startup 2.2x faster
— SASADA Koichi <ko1@...>
2012/10/27
(2012/10/28 7:10), h.shirosaki (Hiroshi Shirosaki) wrote:
[#48728] [ruby-trunk - Bug #7158] require is slow in its bookkeeping; can make Rails startup 2.2x faster
— "tenderlovemaking (Aaron Patterson)" <aaron@...>
2012/11/02
[#48732] Re: [ruby-trunk - Bug #7158] require is slow in its bookkeeping; can make Rails startup 2.2x faster
— Masaya TARUI <tarui@...>
2012/11/02
Thank you for the careful work.
[#48032] [Backport93 - Backport #7174][Open] Advocating for backporting 36811 — "jonforums (Jon Forums)" <redmine@...>
8 messages
2012/10/16
[#48086] [Backport93 - Backport #7174][Assigned] Advocating for backporting 36811
— "usa (Usaku NAKAMURA)" <usa@...>
2012/10/19
[#48040] Should Hash#dup automatically rehash — Aaron Patterson <tenderlove@...>
Hi,
5 messages
2012/10/17
[#48072] [ruby-trunk - Bug #7184][Open] --disable-gems commandline parameter does not show up with ruby -h — "steenslag (siep korteling)" <s.korteling@...>
10 messages
2012/10/18
[#48132] [ruby-trunk - Bug #7201][Open] Setting default_external affects STDIN encoding but default_internal does not — "brixen (Brian Ford)" <brixen@...>
6 messages
2012/10/21
[#48154] Patch to test_ssl to validate server-side support for SNI — Patrick Toomey <ptoomey3@...>
I recently made a pull request to JRuby (
4 messages
2012/10/22
[#48675] Re: Patch to test_ssl to validate server-side support for SNI
— Charles Oliver Nutter <headius@...>
2012/10/31
We have incorporated Patrick's SNI patch for upcoming release JRuby
[#48191] [ANN] 2.0.0 feature freeze — Yusuke Endoh <mame@...>
Japanese later; 日本語は後で
37 messages
2012/10/24
[#48197] Re: [ANN] 2.0.0 feature freeze
— Rodrigo Rosenfeld Rosas <rr.rosas@...>
2012/10/24
Em 24-10-2012 09:39, Yusuke Endoh escreveu:
[#48696] Re: [ANN] 2.0.0 feature freeze
— SASADA Koichi <ko1@...>
2012/11/01
(2012/10/24 5:39), Yusuke Endoh wrote:
[#48701] Re: [ANN] 2.0.0 feature freeze
— Yusuke Endoh <mame@...>
2012/11/01
Hello ko1,
[#48712] Re: [ANN] 2.0.0 feature freeze
— Marc-Andre Lafortune <ruby-core-mailing-list@...>
2012/11/01
Hi,
[#48713] Re: [ANN] 2.0.0 feature freeze
— Yusuke Endoh <mame@...>
2012/11/01
AFAIK matz has not accepted #6636 completely yet.
[#48797] Re: [ANN] 2.0.0 feature freeze
— Clay Trump <clay.trump@...>
2012/11/03
Sorry, late to the party, but what's the status of #6679?
[#48798] Re: [ANN] 2.0.0 feature freeze
— =?KOI8-R?B?4NLJyiDzz8vPzM/X?= <funny.falcon@...>
2012/11/03
What status of #6638 <https://bugs.ruby-lang.org/issues/6638>
[#48260] [ruby-trunk - Bug #7214][Open] Ruby 2.0 breaks support for some debugging tools — "banister (john mair)" <jrmair@...>
22 messages
2012/10/25
[#49657] [ruby-trunk - Bug #7214] Ruby 2.0 breaks support for some debugging tools
— "denofevil (Dennis Ushakov)" <dennis.ushakov@...>
2012/11/20
[#48292] [ruby-trunk - Bug #7216][Open] object.c defines clone method for objects that cannot be cloned. — "therevmj (Michael Johnson)" <mj@...>
6 messages
2012/10/26
[#48315] [ruby-trunk - Bug #7220][Open] StringIO#initialize_copy causes aliasing between the objects — "brixen (Brian Ford)" <brixen@...>
13 messages
2012/10/26
[#48475] [ruby-trunk - Feature #3222] Can bignums have singleton class & methods? — "matz (Yukihiro Matsumoto)" <matz@...>
4 messages
2012/10/27
[#48497] Re: [ruby-trunk - Feature #3222] Can bignums have singleton class & methods?
— SASADA Koichi <ko1@...>
2012/10/27
(2012/10/27 23:25), matz (Yukihiro Matsumoto) wrote:
[#48551] [ruby-trunk - Feature #7241][Open] Enumerable#to_h proposal — "nathan.f77 (Nathan Broadbent)" <nathan.f77@...>
23 messages
2012/10/29
[#48587] [ruby-trunk - Feature #7241] Enumerable#to_h proposal
— "rosenfeld (Rodrigo Rosenfeld Rosas)" <rr.rosas@...>
2012/10/30
[#48625] Re: [ruby-trunk - Feature #7241] Enumerable#to_h proposal
— Aaron Patterson <tenderlove@...>
2012/10/30
On Tue, Oct 30, 2012 at 07:58:33PM +0900, rosenfeld (Rodrigo Rosenfeld Rosas) wrote:
[#48631] Re: [ruby-trunk - Feature #7241] Enumerable#to_h proposal
— Rodrigo Rosenfeld Rosas <rr.rosas@...>
2012/10/30
Em 30-10-2012 16:23, Aaron Patterson escreveu:
[#48679] [ruby-trunk - Feature #905] Add String.new(fixnum) to preallocate large buffer — "headius (Charles Nutter)" <headius@...>
4 messages
2012/10/31
[ruby-core:48350] [ruby-trunk - Feature #3917][Closed] [proposal] called_from() which is much faster than caller()
From:
"ko1 (Koichi Sasada)" <redmine@...>
Date:
2012-10-26 21:02:38 UTC
List:
ruby-core #48350
Issue #3917 has been updated by ko1 (Koichi Sasada).
Status changed from Feedback to Closed
I close this ticket.
Let's discuss naming issue with
https://bugs.ruby-lang.org/issues/7051
----------------------------------------
Feature #3917: [proposal] called_from() which is much faster than caller()
https://bugs.ruby-lang.org/issues/3917#change-31660
Author: kwatch (makoto kuwata)
Status: Closed
Priority: Normal
Assignee: ko1 (Koichi Sasada)
Category: core
Target version: 2.0.0
=begin
I propose to introduce Kernel#called_from() which is similar to caller()
but much faster than it.
Background
----------
There are some cases to want to know from where current method is called.
In this case, Kernel#caller() is used.
But Kernel#caller() has performance issues for these cases.
* caller() retrieves entire stack frame. It is too heavy.
* caller() returns an array of "filename:linenum in `method'" string.
User must parse it and retrieve filename and linenum by rexp.
It is also very heavy weight task.
Therefore I propose Kernel#called_from() which is very light weight
compared to caller(). A certain benchmark shows that called_from()
is more than 20 times faster tan caller().
現在のメソッドがどこから呼び出されたかを知りたい場合がときどきある。
こういう場合は通常 Kernel#caller() が使われる。
しかし Kernel#caller() は、こういった用途ではパフォーマンスが非常に悪い。
* caller() はスタックフレームをすべて取り出す。これは非常に重い操作。
* caller() は "ファイル名:行番号 in `メソッド名'" という文字列の配列を返す。
ユーザは正規表現を使ってこの文字列をわざわざパースしなければならない。
これも重い操作。
そのため、Kernel#called_from() を追加することを提案する。
このメソッドは caller() と比べて非常に動作が軽く、ベンチマークでは
called_from() は caller() と比べて20倍以上高速。
Spec
-----
call-seq:
called_from(start=1) -> array or nil
Returns file name, line number, and method name of the stack.
The optional _start_ parameter represents the number of stack
entries to skip.
Returns +nil+ if _start_ is greater than the size of
current execution stack.
Raises ArgumentError if _start_ is negative value.
Example code
------------
# example.rb
1: def f1()
2: f2()
3: end
4: def f2()
5: f3()
6: end
7: def f3()
8: p called_from() #=> ["example.rb", 5, "f2"]
9: p called_from(0) #=> ["example.rb", 9, "f3"]
10: p called_from(1) #=> ["example.rb", 5, "f2"]
11: p called_from(2) #=> ["example.rb", 2, "f1"]
12: p called_from(3) #=> ["example.rb", 15, "<main>"]
13: p called_from(4) #=> nil
14: end
15: f1()
Use Case
--------
Case 1: logging method
def log_info(message)
filename, linenum, _ = called_from() # !!!
@logger.info "#{filename}:#{linenum}: #{message}"
end
Case 2: debug print
def debug(message)
filename, linenum, _ = called_from() # !!!
$stderr.puts "*** DEBUG: #{filename}:#{linenum}: #{message}"
end
Case 3: deprecation message
def send(*args)
filename, linenum, _ = called_from() # !!!
msg = "`send()' is deprecated. use `__send__()' instead."
msg << " (file: #{filename}, line: #{linenum})"
$stderr.puts "*** warning: #{msg}"
__send__(*args)
end
Case 4: ActiveSupport::Testing::Pending
module ActiveSupport::Testing::Peding
def pending(description = "", &block)
:
#caller[0] =~ (/(.*):(.*):in `(.*)'/) # original
#@@pending_cases << "#{$3} at #{$1}, line #{$2}" # original
#print "P" # original
filenemae, linenum, method = called_from() # !!!
@@pending_cases << "#{method} at #{filename}, line #{linenum}"
print "P"
:
end
end
Case 5: activesupport/lib/active_support/core_ext/module/delegation.rb
class Module
def delegate(*methods)
:
#file, line = caller.first.split(':', 2) # original
#line = line.to_i # original
file, line, _ = called_from() # !!!
:
module_eval(<<-EOS, file, line - 5)
:
end
end
Case 6: caching helper for template system
def cache_with(key)
data, created_at = @_cache_store.get(key)
filename, = called_from() # !!!
## if template file is newer than cached data then clear cache.
## (performance is very important in this case.)
if created_at < File.mtime(filename)
data = nil
@_cache_store.del(key)
end
##
if data.nil?
len = @_buf.length
yield
data = @_buf[len..-1]
@_cache_store.set(key, data)
else
@_buf << data
end
nil
end
## in template file
<% cache_with("orders/#{@order.id}") do %>
<p>Order ID: <%=h @order.id %></p>
<p>Customer: <%=h @order.customer.name %></p>
<% end %>
Benchmark
---------
Attached benchmark shows that called_from() is much faster than caller().
This is very important for logging or template timestamp check.
$ ./ruby -s bench.rb -N=100000
user system total real
caller()[0] 1.890000 0.010000 1.900000 ( 1.941812)
caller()[0] (retrieve) 2.190000 0.010000 2.200000 ( 2.225966)
called_from() 0.100000 0.000000 0.100000 ( 0.102810)
called_from() (retrieve) 0.100000 0.000000 0.100000 ( 0.102133)
Another Solutions
-----------------
Adding new gobal function may be refused.
The followings are another solutions instead of new global function.
* Extend caller() to take 'count' parameter.
For example:
start = 1
count = 1
caller(start, count) #=> ["filename:linenum in `method'"]
* Extend caller() to take 'conbine' flag.
For example:
start = 1
count = nil
conbine = false
caller(start, count, conbine)
#=> [["filename", linenum, "method"],
# ["filename", linenum, "method"],
# .... ]
* Add new standard library 'called_from.so' instead of Kernel#called_from().
新しいグローバル関数を導入するのは拒絶される可能性が高い。
その場合は、caller()を拡張してcalled_from()相当のことができるように
してもらえるとうれしい。
あるいは Kernel#called_from() ではなくても called_from.so を標準添付
する方針でもいい。
Note
----
* I tried to implement the above solutions, but failed because
vm_backtrace_each() seems to search stack frames in the reverse
order of what called_from() requires.
* I can implement called_from() as user library in Ruby 1.8.
http://rubygems.org/gems/called_from
It is allowed to access to stack frame in Ruby 1.8, but no in 1.9.
This is why I submit this propose.
* 実は上記のanother solutionsを実装しようとしたが、called_from() では
直近のスタックフレームから辿りたいのに対し、vm_backtrace_each() は
逆の順番で辿ることしかできないようなので、実装を諦めた。
* Ruby 1.8 では拡張モジュールからスタックフレームにアクセスできるので
ライブラリとして実装した。
http://rubygems.org/gems/called_from
けど1.9ではスタックフレームへのアクセスができないので、ライブラリが
作れない。そのため今回このような提案をしてみた。
=end
--
http://bugs.ruby-lang.org/