[#55853] ruby 1.9.3 p448 breaks ABI — V咜 Ondruch <v.ondruch@...>

Hi,

13 messages 2013/07/08

[#55951] [ruby-trunk - Bug #8625][Open] IO#read(len, buf) shortens buf even if data is not read actually — "no6v (Nobuhiro IMAI)" <nov@...>

10 messages 2013/07/11

[#55976] [ruby-trunk - Feature #8629][Open] Method#parameters should include the default value — "rosenfeld (Rodrigo Rosenfeld Rosas)" <rr.rosas@...>

13 messages 2013/07/12

[#55985] [ruby-trunk - Feature #8631][Open] Add a new method to ERB to allow assigning the local variables from a hash — "rosenfeld (Rodrigo Rosenfeld Rosas)" <rr.rosas@...>

19 messages 2013/07/12

[#56004] [ruby-trunk - Feature #8636][Open] Documentation hosting on ruby-lang.org — "zzak (Zachary Scott)" <e@...>

18 messages 2013/07/15

[#56019] [ruby-trunk - Feature #8639][Open] Add Queue#each — "avdi (Avdi Grimm)" <avdi@...>

15 messages 2013/07/15

[#56027] [CommonRuby - Feature #8640][Open] Add Time#elapsed to return nanoseconds since creation — "tenderlovemaking (Aaron Patterson)" <aaron@...>

24 messages 2013/07/15

[#56041] [CommonRuby - Feature #8643][Open] Add Binding.from_hash — "rosenfeld (Rodrigo Rosenfeld Rosas)" <rr.rosas@...>

26 messages 2013/07/16

[#56087] [ruby-trunk - Feature #8658][Open] Process.clock_gettime — "akr (Akira Tanaka)" <akr@...>

23 messages 2013/07/19

[#56096] [CommonRuby - Feature #8661][Open] Add option to print backstrace in reverse order(stack frames first & error last) — "gary4gar (Gaurish Sharma)" <gary4gar@...>

18 messages 2013/07/20

[#56193] [ruby-trunk - Bug #8693][Open] lambda invoked by yield acts as a proc with respect to return — "rits (First Last)" <redmine@...>

33 messages 2013/07/26

[#56274] [ruby-trunk - Bug #8709][Open] Dir.glob should return sorted file list — "tommorris (Tom Morris)" <tom@...>

19 messages 2013/07/30

[ruby-core:55906] [ruby-trunk - Bug #8612][Assigned] nil in ERB::Util.url_encode

From: "zzak (Zachary Scott)" <zachary@...>
Date: 2013-07-10 05:12:15 UTC
List: ruby-core #55906
Issue #8612 has been updated by zzak (Zachary Scott).

Category set to lib
Status changed from Open to Assigned
Assignee set to seki (Masatoshi Seki)


----------------------------------------
Bug #8612: nil in ERB::Util.url_encode
https://bugs.ruby-lang.org/issues/8612#change-40405

Author: fotos (Fotos Georgiadis)
Status: Assigned
Priority: Normal
Assignee: seki (Masatoshi Seki)
Category: lib
Target version: 
ruby -v: 1.9.3p448, 2.0.0p255
Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN


=begin
We hit a bug while using Rails and trying to URL encode an ActiveSupport::SafeBuffer. I have managed to reproduce it using a small test case for Ruby 1.9.3 and Ruby 2.0.0 (both attached) that shows a minimum set of requirements to trigger the bug. The issue seems to be fixed in trunk (2.1) but I couldn't find the relevant commit(s).

To reproduce:
  require 'erb'

  class MyString < String
    def to_s
      self
    end

    def gsub(*args, &block)
      to_str.gsub(*args, &block)
    end
  end

  string = "\xCE\x94\xCE\xBF\xCE\xBA\xCE\xB9\xCE\xBC\xCE\xAE".force_encoding("UTF-8")

  ERB::Util.u(MyString.new(string))

Expected outcome:

The URL encoding should work and it should encode the characters properly (according to the spec).

Actual outcome:

  NoMethodError: undefined method `unpack' for nil:NilClass
    /Users/fotos/Playground/OpenSource/ruby/lib/erb.rb:952:in `block in url_encode'
    /Users/fotos/Playground/OpenSource/ruby/test/erb/test_erb.rb:71:in `gsub'
    /Users/fotos/Playground/OpenSource/ruby/test/erb/test_erb.rb:71:in `gsub'
    /Users/fotos/Playground/OpenSource/ruby/lib/erb.rb:951:in `url_encode'
    /Users/fotos/Playground/OpenSource/ruby/test/erb/test_erb.rb:491:in `test_url_encode_string_subclass'

Using

Workaround:

Yielding the match and using it instead of $& (last match) seems to work properly as demonstrated in the patch.

Thanks

PS. Some credits go out to Aggelos Orfanakos (@agorf) for triggering the bug! :-)
=end


-- 
http://bugs.ruby-lang.org/

In This Thread