ruby-core

Issue #9699 has been updated by Thomas Thomassen.


Can this patch be back ported to Ruby 2.1 or 2.0?

----------------------------------------
Bug #9699: Cannot require .so file on Windows if the file path is unicode (=
Includes patch)
https://bugs.ruby-lang.org/issues/9699#change-46099

* Author: Bugra Barin
* Status: Closed
* Priority: Normal
* Assignee: cruby-windows
* Category: platform/windows
* Target version: current: 2.2.0
* ruby -v: 2.0.0 and later
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
It doesn't seem possible to load a C extension that is inside a non-ascii p=
ath.
To reproduce:
- Extract the attached zip file (with a decent unzip program such as 7-zip,=
 that preserves unicode paths)
- cd to where you extracted
- launch irb
- require './foo.rb' (All this does is require a simple so file inside the =
folder '=E3=81=A6=E3=81=99=E3=81=A8')
- You'll see a failure

The culprit is in function dln_load, it uses the ANSI version of LoadLibrar=
y and passes in the char* path given to the function. My patch converts it =
to wide char and uses LoadLibraryW. I have assumed that the given path is U=
TF-8 encoded, which seems to work but I am not sure if this is a safe assum=
ption.

I hope the patch is in the right format, I wasn't sure. Thanks for your tim=
e!
Bugra


---Files--------------------------------
require_so_bug_win32.zip (16.3 KB)
dln_load.patch (1.41 KB)


--=20
https://bugs.ruby-lang.org/