Activity
From 02/21/2020 to 02/27/2020
02/27/2020
-
10:13 PM Bug #16660 (Rejected): Struct#deconstruct_keys inconsistent behavior
- Here is an example of a kind of surprising (at least to me) `Struct#deconstruct_keys` behaviour:
```ruby
klass = ... -
09:56 PM Feature #16597: missing poll()
- Updated patch
-
07:08 PM Bug #9573 (Open): descendants of a module don't gain its future ancestors, but descendants of a class, do
-
07:03 PM Bug #9573 (Closed): descendants of a module don't gain its future ancestors, but descendants of a class, do
- Applied in changeset commit:git|3556a834a2847e52162d1d3302d4c64390df1694.
----------
Make Module#include affect the ... -
08:23 AM Bug #9573: descendants of a module don't gain its future ancestors, but descendants of a class, do
- The patch for `include` looks OK to me. To ensure there are no unseen compatibility issues, I'd like to experiment wi...
-
- When calling Module#include, if the receiver is a module,
walk the subclasses list and include the argument module in... -
- Applied in changeset commit:git|54499d78109037d7c37bc09a8c3ffa0050da5aca.
----------
Remove support for passing nil ... -
- `IO#ungetc` should be fixed. The patch looks good to me.
Matz.
- 06:18 PM Revision 1ca3a221 (git): * 2020-02-28 [ci skip]
-
- Fixes [Bug #13675]
-
04:31 PM Feature #16644: qualified const init (self::CONST1 = 1) should be allowed in methods
- > I'd rather make all const re-assignment error
I don't disagree, actual const re-assignment, dynamically detected... -
-
- Use `const_set`. I'd rather make all const re-assignment error if compatibility does not matter.
Matz.
-
04:16 PM Misc #16659 (Open): Documentation on Regexp missing for absence pattern (?~pat)
- The absence pattern `(?~pat)` available since Ruby 2.4.1 is [not yet documented on `Regexp`](https://git.ruby-lang.or...
-
11:08 AM Feature #16652: Use RubyGems facilities to install Gems during Ruby installation
- Since the first PR was merged, I have updated the second PR [1] to apply cleanly.
[1]: https://github.com/ruby/rub... -
10:49 AM Feature #15605: json library needs more frequent releases
- What's the status on this ?
I understand that a part of the gem is now edited from ruby/ruby, but that exclude t... -
10:14 AM Bug #16656: Fix wrong RegExp in rbinstall to install the default gems from expanded sources again
- Also found the same error myself and fixed it at https://github.com/ruby/ruby/pull/2930.
-
- I have submitted [1] to fix the wrong RegExp from [2].
[1]: https://github.com/ruby/ruby/pull/2933
[2]: https:/... -
09:52 AM Misc #16630: Deprecate pub/ruby/*snapshot* and use pub/ruby/snapshot/* instead
- I created [pull request to change links to snapshot](https://github.com/ruby/www.ruby-lang.org/pull/2379).
-
- The PR #2888 [1] dropped DTrace `method__cache__clear` hook without replacement. Was this intentional? If yes, then t...
-
08:08 AM Bug #15409: OpenStruct error when attribute is called 'method'
- @marcandre
I talked with matz about this ticket, and he said it would be good to revert 3bf9b2f0473550caa73468908ac3... -
- Hmm, it was caused by OpenStruct performance pull-request. Maybe we should revert the PR?
Matz.
-
- You may think it's handy. But it's far more complicated than you think. For example, `define_method` may be called fr...
-
- We have found out that `#method_missing` (and `#send`) needed leading arguments otherwise we cannot use argument forw...
-
- Working at #16651, I wonder why the release tarball ships with the bundled gem in form of .gem packages as well as th...
-
- We discussed this issue at the dev-meeting, and it requires @Glass_saga's review.
Note:
* It is uninterruptable... -
- It is not obvious to me that `#case?` is useful. We need a real-world use-case.
* I don't like the name `case?`
*... -
04:51 AM Feature #15722: `Kernel#case?`
- What about using `#when?` instead of `#case?`?
```ruby
bar # => "bar"
flag1 = case bar; when "foo", "bar", "baz"... -
- The current behavior should be as it is. If there can be a clearer description in the document, PR welcome.
Matz. -
05:16 AM Misc #16483 (Closed): How about stopping new *.tar.bz2 releases?
- From Ruby 2.8, I'll provide only .zip, .gz, and .xz (not provide .bz2).
For 2.7.x or prior we'll still provide also ... -
04:33 AM Revision 229ba121 (git): Merge racc from upstream repository.
- * Support Ruby 2.4's frozen string literals.
* Remove VCS revisions headers. -
02:08 AM Revision 9a422fc0 (git): Update docs for Time#at method [ci skip]
- Add docs about all possible options for the `in` argument.
-
01:50 AM Revision 18674aef (git): check imemo_type
- check imemo_type to debug
http://ci.rvm.jp/results/trunk-vm-asserts@silicon-docker/2744755 -
- to suppress a warning "variable 'check' set but not used"
02/26/2020
-
- a qualified const init is so similar to meta-programming `const_set` that there's no reason to block it
```ruby
modu... -
07:40 PM Bug #16654: Segfault in rb_str_hash
- The application I'm reproducing it on is here: https://github.com/codetriage/codetriage
I think you should be able... -
07:11 AM Bug #16654: Segfault in rb_str_hash
- Nobu, This looks like Mac to me maybe llvm related?
-
05:29 AM Bug #16654 (Feedback): Segfault in rb_str_hash
- I couldn't reproduce it with a simple file.
Could you try with the master, and could your "config/environment.rb" be... -
- MiniTest::Unit (superclass of Test::Unit::Runner) does not has
default seed parameter, but assigned after initializin... -
- To avoid `srand(0)` effect in the other tests, call `srand($seed)`
at the beginning of each test (setup).
[Feature #1... -
- This reverts commit 7c1553e91db07fed4fed3287b50304f1c69a685d.
It breaks some tests. -
- Applied in changeset commit:git|116c6320956ce80efcb1db849a190ebd7f8c8ad3.
----------
don't ignore `--seed` option
`... -
- # Points
* call `srand($seed)` before each test. `$seed` is given seed number by `--seed N`
# Background
Som... - 05:32 PM Revision 8296da88 (git): * 2020-02-27 [ci skip]
-
- To avoid `srand(0)` effect in the other tests, call `srand($seed)`
at the beginning of each test (setup).
[Feature #1... -
- `--seed N` option is just ignored so respect this option.
[Feature #16655]
Also making "Run options" display pretty. -
02:38 PM Bug #16647: Redefining $/ causes irb to misbehave
- Eregon (Benoit Daloze) wrote in #note-1:
> Out of curiosity, why do you overwrite $/?
>
> My personal opinion is ... -
08:37 AM Revision 83705c42 (git): Add missing free on cc_entries
- Looks like an oversight in b9007b6c548f91e88fd3f2ffa23de740431fa969 and
7ec23593746c8ccabd6c005cc34dde77d564c6c9. -
- just in case.
-
- Fixed a TODO in b9007b6c548f91e88fd3f2ffa23de740431fa969
-
- Add a little more details in 7ec23593746c8ccabd6c005cc34dde77d564c6c9
-
- shared by ko1
-
- Simply use `File.basename` to remove the directory name (and
suffix), instead of `gsub` which can replace unintended ... -
- It was unnecessary in b9007b6c548f91e88fd3f2ffa23de740431fa969
-
07:01 AM Bug #16521 (Closed): ST_DEBUG not working
- Applied in changeset commit:git|fbd7f08e922cdf1a4be7a71aa056659971c81dab.
----------
kill ST_DEBUG [Bug #16521]
Thi... -
- This compile-time option has been broken for years (at least since
commit 4663c224fa6c925ce54af32fd1c1cbac9508f5ec, a... -
- This compile-time option has been broken for years (at least since
commit 49369ef17316cd5d5819b038f286e1d951972b52, a... -
- ISO/IEC 9899:1999 section 6.10.3 paragraph 11 explicitly states that
"If there are sequences of preprocessing tokens ... -
- 02:04 AM Revision 9d6d5315 (git): Cache destination dir.
- It is not necessary to strip the `destdir` prefix every iteration, when
it can be done just once. - 02:04 AM Revision b8a8fdba (git): Properly detect mode for binaries.
- .gemspec files specifies not just `bin`, but also other directories.
- 02:04 AM Revision e087b029 (git): Use class variable `@src_dir` instead of local `path`.
- The local `path` variable does not provide any additional value and was
kept around just for clarity for easier revie... - 02:04 AM Revision c9fab1ac (git): Use local `{dir,prog,data}_mode` variables instead of globals.
- This just gets the `RbInstall::DirPackage` closer by functionality to
`Gem::Package`. - 02:04 AM Revision 6609940a (git): Use `$script_mode` instead of `$prog_mode` for gem inistallation.
- rbinstall is using `$script_mode` and `$prog_mode`. However, the
`$script_mode` fallbacks to `$prog_mode` if not prov... - 02:04 AM Revision e960ef6f (git): Use `Gem::Package` like object instead of monkey patching.
- 1. This is similar to what RubyGems does and it is less magic [[1]].
2. It avoids deprecated code paths in RubyGems [... -
- Mingw has meant "mingw on cygwin", and msys has not been a supported platform.
-
- Fix up 66d1900423e6fb9774c2fe72dba8c2968b54d7ab, `RubyVM::MJIT` is
available since ruby 2.6. -
- Looking through the repository history, the patch attached to this issue is mostly implemented by commit:6424d316b993...
02/25/2020
-
- Does not reproduce on 2.5.5, and reproduces on 2.6.0
Unfortunately, doesn't reproduce with a simple script, e.g.:
`... -
- This reproduces on 2.7.0 as well (though the thing calling `rb_str_hash` was different, this time `objspace_each_obje...
-
- Seen in ruby 2.6.5.
```
-- C level backtrace information -------------------------------------------
/Users/nate... -
06:54 PM Feature #16511: Staged warnings and better compatibility for keyword arguments in 2.7.1
- @Eregon thanks for your reply.
I won't bother making a point-by-point counterargument because it would be redundant ... - 06:43 PM Revision 672213ef (git): Document that Array#index and find_index are aliases [ci skip]
- 05:27 PM Revision 6c66761c (git): * 2020-02-26 [ci skip]
-
- To prevent CI failures like
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2739995 -
- Attaching test and fix.
This fixes the problem with not raising exception but now my patched interpreter tends to cr... -
- Looks like the issue is using multiple domain names instead of IP addresses for the :nameserver option. Single domai...
-
09:08 AM Bug #16653 (Rejected): Weird behaviour of Resolv module
- I have to deal with DNS request. Here is some examples.
When I ask A records for example.com at some public DNS se... -
- Extract bundled gems under ".bundle/gems" and get rid of
duplication which cause constant redefinition warnings at
`t... -
10:34 AM Feature #15921: R-assign (rightward-assignment) operator
- I think `=>` is okay, but in case we want to use a keyword (ordinary word) for this feature, I think `as` would be go...
-
-
- We would like to skip this extension library when libstdc++ is missing.
To avoid such situation let's use try_link in... -
- GC can invoke just after allocation of jit_unit->cc_entries so
it should be zero-cleared. -
- I talked about this issue with nobu and ko1.
> Is it intentional? or a bug?
As @usa said, it is intentional acc... -
- This code can generate CC objects so we only need to count
existing String objects. -
- ALLOC_N() can causes GC. Sometimes `mjit_copy_job_handler()`
can be called by mjit_worker thread which is not a Ruby ... - 03:53 AM Revision 82d27604 (git): * 2020-02-25 [ci skip]
-
03:53 AM Revision fa1ec604 (git): Fix wrong documentation for return value of Pathname#fnmatch
-
- I agree with your proposal. It's difficult to handle for us continuously.
@matz
Can we remove it? -
02:24 AM Feature #16652: Use RubyGems facilities to install Gems during Ruby installation
- I glanced at rbinstall.rb briefly; for those interested, the link should be here:
https://github.com/ruby/ruby/blo...
02/24/2020
-
11:38 PM Feature #16648: improve GC performance by 5% with builtin_prefetch
- I ran the patch on some included GC benchmarks in the repo and it doesn't seem to be a pure win (built-ruby is the pa...
-
- There is a bug with handling POLLNVAL in the new code.
-
- This was already fixed in master at commit:f8a8f055123bc81fc13fa295b936504196df0da4, which changed it so ruby2_keywor...
-
- Currently, `tools/rbinstall` uses quite some custom code to install gems instead of using functionality available in ...
-
02:58 PM Bug #16647 (Closed): Redefining $/ causes irb to misbehave
- It was a problem with Reline. I fixed it by https://github.com/ruby/reline/pull/129.
> My personal opinion is we s... -
09:03 AM Bug #16647: Redefining $/ causes irb to misbehave
- Related to https://bugs.ruby-lang.org/issues/14240
changing these variables is deprecated now, and it shows a warning -
06:55 AM Bug #16651 (Closed): Extensions Do Not Compile on Mingw64 with mingw32-make
- When mkmf.rb creates a Makefile for an extension, it will generate something that looks like this:
```makefile
sr... -
- Using the latest version of mingw64 and msys2, neither ruby 2.6.5 nor 2.7.0 compile.
The issue is with miniruby.ex... -
- Applied in changeset commit:git|8b6e2685a4b7c7de905f7ed60c02ef85e0724754.
----------
Fixed symbol misused as ID
`rb... -
- `String#encode` document says fallback can be a Hash, a Proc, a Method or an object which has `[]` method.
> Sets... -
- `rb_funcallv_public` and `rb_respond_to` require an `ID`, not a
`Symbol`. [Bug #16649] -
-
- rss 0.2.9 is tagged without the "v" prefix.
-
02/23/2020
-
11:53 PM Feature #16456: Ruby 2.7 argument delegation (...) should be its own kind of parameter in Method#parameters
- I'd definitely like to see this as well. It'd be useful for Sorbet since it uses the parameters method to reconstruct...
- 03:28 PM Revision f88d209b (git): * 2020-02-24 [ci skip]
-
03:28 PM Revision 281b3500 (git): Add pattern matching documentation
- Add separate doc/syntax/pattern_matching.rdoc, add
link to control_expressions.rdoc.
The documentation is "reverse-e... -
02:24 PM Feature #16511: Staged warnings and better compatibility for keyword arguments in 2.7.1
- Thanks for writing that out.
I think in general tracking whether a Hash is keywords or positional dynamically make... -
- Out of curiosity, why do you overwrite $/?
My personal opinion is we should deprecate all these variables affectin... -
- Applied in changeset commit:git|6298ec2875a6f1a1e75698c96ceac94362f20bcf.
----------
Warn non-nil `$\` [Feature #14240] -
-
-
-
- This reverts commit c7b71af9e21b3f0b8fe413a3c20cf4bd633c40d0, as
an example in bundler expects untouch PATH.
02/22/2020
-
- These are two different things. Ruby always warns for assigning to an existing constant, regardless of using `const_...
-
- Can you please run the failing code from the command line and include the output? The awd files provided are binary ...
-
06:03 PM Feature #16648 (Open): improve GC performance by 5% with builtin_prefetch
- The mark phase of non-incremental major GC is (I believe) dominated by pointer chasing. One way we can improve that ...
- 03:38 PM Revision f85ca4c8 (git): * 2020-02-23 [ci skip]
-
03:32 PM Revision 77dcc2c8 (git): hash.c: [DOC] fix examples for ENV.merge!
-
-
02:05 AM Bug #16646: OpenSSL::VERSION is not defined (moved to ruby/openssl)
- See https://github.com/ruby/openssl/issues/347
Please close. OpenSSL should have a new release soon... -
-
- Thanks for the fix nobu! (https://github.com/ruby/ruby/commit/5b29ea0845c14092abd866ce0183c52635bade4c)
-
- Applied in changeset commit:git|5b29ea0845c14092abd866ce0183c52635bade4c.
----------
Proc from Symbol needs a receiv... -
-
-
- iseq->body->jit_unit is not available if USE_MJIT==0 .
-
- > treating non-Symbol keys as keywords if the method accepts arbitrary keywords is expected behavior
Yes, I was awar... -
- Yes, treating non-Symbol keys as keywords if the method accepts arbitrary keywords is expected behavior, as mentioned...
-
- So its arity should be -2 instead of -1.
[Bug #16640]
https://bugs.ruby-lang.org/issues/16640#change-84337 -
- Unused CI (introduced from peephole optimization, etc) can be NULL
so introduce NULL check. -
01:25 AM Revision af12e386 (git): More ENV rdoc [ci skip]
-
- In ruby/ruby, the tests run on both readline & reline by creating four test classes:
```
TestReadline
TestReadlineHis... -
- Applied in changeset commit:git|b9007b6c548f91e88fd3f2ffa23de740431fa969.
----------
Introduce disposable call-cache... - 12:59 AM Revision d7984d0f (git): * remove trailing spaces. [ci skip]
-
- This patch contains several ideas:
(1) Disposable inline method cache (IMC) for race-free inline method cache
* ... -
- Now, rb_call_info contains how to call the method with tuple of
(mid, orig_argc, flags, kwarg). Most of cases, kwarg ...
02/21/2020
-
-
- I can not answer your question but I believe matz mentioned the change several times in different
talks before. So a... -
- In ruby 2.7 non-symbol keys are now accepted as keywords, resulting in the following change in behavior:
```ruby
... -
- If I start irb and then do:
``` ruby
$/ = "asdf"
```
then every character I type shows a newline on the irb... -
- There are several ways to fix this, maybe add to openssl.rb?
Noticed in several platforms... - 03:45 PM Revision 5a89c057 (git): * 2020-02-22 [ci skip]
-
- With refinements, too.
-
-
-
- https://github.com/ruby/irb/commit/dbc7b059c7
-
-
-
-
- test/net/http/test_https.rb: rename fixture methods to read_fixture
because it conflicts with test-unit gem. -
- I guess this is because you're not using the latest rubygems. Could you run `gem env version` and check that you have...
-
- jeremyevans0 (Jeremy Evans) wrote in #note-3:
> Dan0042 (Daniel DeLorme) wrote in #note-2:
> > Are you seriously te... -
- Dan0042 (Daniel DeLorme) wrote in #note-2:
> Are you seriously telling me that you consider it normal and correct th... -
- Are you seriously telling me that you consider it normal and correct that `obj.dig(**kw)` is _not_ equivalent to `[ob...
-
-
-
- As mentioned in https://bugs.ruby-lang.org/issues/16511#note-17
it seems very unlikely this triggers in practice, be... -
- The arity should actually be `-2` which means 1 required arguments + any number of optional arguments.
- 04:31 AM Revision 4643bf5d (git): * 2020-02-21 [ci skip]
-
Also available in: Atom