Page MenuHomePhabricator
Differential D64409

Bug 1593837 - Filter WS messages with regular expressions. r=Harald,Honza
ClosedPublic
Actions

Authored by outloudvi on Feb 26 2020, 5:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 17 2025, 8:10 PM
Unknown Object (File)
Oct 16 2025, 11:35 AM
Unknown Object (File)
Oct 15 2025, 10:28 PM
Unknown Object (File)
Oct 13 2025, 6:20 AM
Unknown Object (File)
Sep 25 2025, 8:38 PM
Unknown Object (File)
Sep 15 2025, 1:02 PM
Unknown Object (File)
Sep 13 2025, 3:25 PM
Unknown Object (File)
May 27 2025, 8:05 PM
View All 41 Files
Subscribers
None

Details

Reviewers
• Harald
Honza
Commits
rMOZILLACENTRAL830eca484fef: Bug 1593837 - Filter WS messages with regular expressions. r=Honza
Bugzilla Bug ID
1593837

Diff Detail

Event Timeline

outloudvi created this revision.Feb 26 2020, 5:01 PM
Herald added a project: secure-revision. · View Herald TranscriptFeb 26 2020, 5:01 PM
Harbormaster completed remote builds in B165124: Diff 234478.Feb 26 2020, 5:01 PM
phab-bot requested review of this revision.Feb 26 2020, 5:01 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
outloudvi added a child revision: D64410: Bug 1593837 - Add corresponding tests. r=Honza.Feb 26 2020, 5:02 PM
outloudvi added a comment.EditedFeb 26 2020, 5:05 PM

This commit is the same as D57395. The actual commit I added is D64410, which is the test required by Honza at D57395. Shall be authored w/ Cabezota if possible.

• Harald added a comment.Feb 26 2020, 8:30 PM

Thanks for the quick work @outloudvi!

LGTM feature-wise, leaving the code review to Honza.

Honza accepted this revision.Feb 27 2020, 10:54 AM

Nice and clean, thanks for that patch!

Honza

This revision is now accepted and ready to land.Feb 27 2020, 10:54 AM
Honza mentioned this in D57395: Bug 1593837 - Filter WS messages with regular expressions. r=Harald,Honza.Feb 27 2020, 10:54 AM
Closed by commit rMOZILLACENTRAL830eca484fef: Bug 1593837 - Filter WS messages with regular expressions. r=Honza (authored by outloudvi). · Explain WhyFeb 27 2020, 11:00 AM
This revision was automatically updated to reflect the committed changes.
outloudvi added a commit: rMOZILLACENTRAL830eca484fef: Bug 1593837 - Filter WS messages with regular expressions. r=Honza.

Revision Contents
Changeset List

PathSize
devtools/
client/
netmonitor/
src/
selectors/
27 lines

Diff 235059

View Options

devtools/client/netmonitor/src/selectors/web-sockets.js

Loading...
Privacy · Cookies · Legal