Page MenuHomePhabricator
Differential D64410

Bug 1593837 - Add corresponding tests. r=Honza
ClosedPublic
Actions

Authored by outloudvi on Feb 26 2020, 5:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 5 2025, 11:23 PM
Unknown Object (File)
Oct 16 2025, 12:31 PM
Unknown Object (File)
Oct 16 2025, 3:02 AM
Unknown Object (File)
Oct 15 2025, 2:04 PM
Unknown Object (File)
Oct 13 2025, 6:18 PM
Unknown Object (File)
Sep 28 2025, 8:43 AM
Unknown Object (File)
Sep 26 2025, 12:21 AM
Unknown Object (File)
May 6 2025, 1:05 PM
View All 47 Files
Subscribers
None

Details

Reviewers
Honza
Commits
rMOZILLACENTRALf7dd4fb8ea09: Bug 1593837 - Add corresponding tests. r=Honza
Bugzilla Bug ID
1593837
Summary

This test is based on browser_net-ws-filter-freetext.js.

Depends on D64409

Diff Detail

Event Timeline

outloudvi created this revision.Feb 26 2020, 5:02 PM
Herald added a project: secure-revision. · View Herald TranscriptFeb 26 2020, 5:02 PM
Harbormaster completed remote builds in B165125: Diff 234479.Feb 26 2020, 5:02 PM
phab-bot requested review of this revision.Feb 26 2020, 5:02 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
outloudvi mentioned this in D64409: Bug 1593837 - Filter WS messages with regular expressions. r=Harald,Honza.Feb 26 2020, 5:05 PM

Honza was requiring both text and regex tests in this text in D57395, but since I have already seen the text one in browser_net-ws-filter-freetext.js, this diff only contains the regex one.

Honza accepted this revision.Feb 27 2020, 10:55 AM

Looks good to me, thanks for the help!
Honza

This revision is now accepted and ready to land.Feb 27 2020, 10:55 AM
Closed by commit rMOZILLACENTRALf7dd4fb8ea09: Bug 1593837 - Add corresponding tests. r=Honza (authored by outloudvi). · Explain WhyFeb 27 2020, 11:00 AM
This revision was automatically updated to reflect the committed changes.
outloudvi added a commit: rMOZILLACENTRALf7dd4fb8ea09: Bug 1593837 - Add corresponding tests. r=Honza.

Revision Contents
Changeset List

PathSize
devtools/
client/
netmonitor/
test/
1 line
84 lines

Diff 235060

View Options

devtools/client/netmonitor/test/browser.ini

Loading...
View Options

devtools/client/netmonitor/test/browser_net_ws-filter-regex.js

Loading...
Privacy · Cookies · Legal