Paths

Table of Contentst

Differential D67849

Bug 1566780 - Added another filter frame type for viewing control frames separately r=Honza
ClosedPublic
Actions

Authored by Kish on Mar 23 2020, 1:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Oct 15 2025, 3:36 PM

	Unknown Object (File)
	Oct 15 2025, 4:34 AM

	Unknown Object (File)
	Oct 14 2025, 5:25 AM

	Unknown Object (File)
	Oct 8 2025, 9:19 PM

	Unknown Object (File)
	Jun 15 2025, 1:36 PM

	Unknown Object (File)
	May 30 2025, 11:16 AM

	Unknown Object (File)
	May 27 2025, 4:22 AM

	Unknown Object (File)
	May 24 2025, 11:57 PM

View All 65 Files

Subscribers

Details

Reviewers

Commits

rMOZILLACENTRAL5431843c523d: Bug 1566780 - Added another filter frame type for viewing control frames…
rMOZILLACENTRAL05de83a88c61: Bug 1566780 - Added another filter frame type for viewing control frames…

Bugzilla Bug ID

Summary

Correcting linter errors

Added new logic for toggling control frames by adding a new control frame check variable and toggle function

Preserve controlFrames option when clearing frames. Changed Control Frames to Control in locale

Correct linter errors

Added a separator between received and control. Changed the dropdown title to reflect control frame state

Changed controlFramesEnabled to showControlFrames

Added a comment about showControlFrames and toggleControlFrames

Change ws-early-connection test to check for only 2 frames, skipping the other 2 control frames

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

Kish created this revision.Mar 23 2020, 1:16 PM

Herald added a project: secure-revision. · View Herald TranscriptMar 23 2020, 1:16 PM

Harbormaster completed remote builds in B175267: Diff 248574.Mar 23 2020, 1:16 PM

phab-bot requested review of this revision.Mar 23 2020, 1:17 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: flod. · View Herald TranscriptMar 23 2020, 1:17 PM

Code analysis found 3 defects in the diff 248574:

3 defects found by mozlint-eslint

You can run this analysis locally with:

./mach lint --warnings path/to/file (JS/Python/etc)

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Kish updated this revision to Diff 248612.Mar 23 2020, 2:32 PM

Harbormaster completed remote builds in B175290: Diff 248612.Mar 23 2020, 2:32 PM

flod added inline comments.Mar 23 2020, 2:35 PM

devtools/client/locales/en-US/netmonitor.properties
714	`o`, lowercase, to match the actual character in the label.

Kish added inline comments.Mar 23 2020, 2:39 PM

devtools/client/locales/en-US/netmonitor.properties
714	Also, if the accesskey should be `C` or not? The "copy message" key was `C` so I was not sure if it will conflict with it or not

Code analysis found 2 defects in the diff 248612:

2 defects found by mozlint-eslint

You can run this analysis locally with:

./mach lint --warnings path/to/file (JS/Python/etc)

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Kish updated this revision to Diff 248782.Mar 23 2020, 6:03 PM

Kish edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B175405: Diff 248782.Mar 23 2020, 6:03 PM

Kish updated this revision to Diff 249087.Mar 24 2020, 4:22 AM

Kish edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B175643: Diff 249087.Mar 24 2020, 4:22 AM

Code analysis found 6 defects in the diff 249087:

6 defects found by mozlint-eslint

You can run this analysis locally with:

./mach lint --warnings path/to/file (JS/Python/etc)

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1566780#c15 , not sure if we should overload the select with a mix of multi-select and single-select behaviour – that might be hard to explain. Maybe @victoria has ideas on how to solve this. Could you try adding a toggle in the toolbar for Control?

devtools/client/locales/en-US/netmonitor.properties
710	Do you have a screenshot of how this looks and how much space it takes? Alternatively this could just be "Control".

Kish added inline comments.Mar 24 2020, 5:56 AM

devtools/client/locales/en-US/netmonitor.properties
710	I am attaching a screenshot hereby:

Kish updated this revision to Diff 249093.Mar 24 2020, 6:11 AM

Kish edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B175650: Diff 249093.Mar 24 2020, 6:11 AM

Kish added inline comments.Mar 24 2020, 6:13 AM

devtools/client/locales/en-US/netmonitor.properties
710	After changing it to "Control", it looks like this:

Code analysis found 6 defects in the diff 249093:

6 defects found by mozlint-eslint

You can run this analysis locally with:

./mach lint --warnings path/to/file (JS/Python/etc)

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Kish updated this revision to Diff 249097.Mar 24 2020, 6:53 AM

Kish edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B175654: Diff 249097.Mar 24 2020, 6:53 AM

Looks great, thanks for working on this!

Please see my inline comments

Honza

devtools/client/netmonitor/src/components/websockets/FrameFilterMenu.js
77	Please add a separator in between `received` and `control` { type: "separator", }
81	I don't see the checkbox icon since type is missing, please add: `type: "checkbox",` Also for the other filter items.
devtools/client/netmonitor/src/reducers/web-sockets.js
51	Please add a little comment explaining what the `controlFramesEnabled` is for Also, `showControlFrames` would be a better name (please rename)

This revision now requires changes to proceed.Mar 26 2020, 7:40 AM

Kish updated this revision to Diff 251074.Mar 27 2020, 12:22 PM

Kish edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B177108: Diff 251074.Mar 27 2020, 12:22 PM

Kish updated this revision to Diff 251076.Mar 27 2020, 12:34 PM

Kish edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B177110: Diff 251076.Mar 27 2020, 12:34 PM

Kish marked 2 inline comments as done.Mar 27 2020, 12:39 PM

Kish added inline comments.

devtools/client/netmonitor/src/components/websockets/FrameFilterMenu.js
103	@Honza this will change the title of dropdown to "All (Control)" if showControlFrames is true. But I am guessing this is not the proper way to do this?!

Thanks for working on this, this is nice improvement!

Honza

devtools/client/netmonitor/src/components/websockets/FrameFilterMenu.js
103	I actually like it so, let's keep it there :-)

This revision is now accepted and ready to land.Mar 30 2020, 10:18 AM

Closed by commit rMOZILLACENTRAL05de83a88c61: Bug 1566780 - Added another filter frame type for viewing control frames… (authored by Kish). · Explain WhyMar 30 2020, 10:21 AM

This revision was automatically updated to reflect the committed changes.

Kish added a commit: rMOZILLACENTRAL05de83a88c61: Bug 1566780 - Added another filter frame type for viewing control frames….

• bogdan_tara reopened this revision.Mar 30 2020, 11:47 AM

This revision is now accepted and ready to land.Mar 30 2020, 11:47 AM

• bogdan_tara added a reverting change: rMOZILLACENTRAL670a20bfd18a: Backed out changeset 05de83a88c61 (bug 1566780) for devtools failures….Mar 30 2020, 11:47 AM

Please see my comment here: https://bugzilla.mozilla.org/show_bug.cgi?id=1566780#c25

Honza

This revision now requires changes to proceed.Mar 31 2020, 5:26 AM

Kish updated this revision to Diff 252706.Mar 31 2020, 7:19 AM

Kish edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B178281: Diff 252706.Mar 31 2020, 7:20 AM

Thanks for quick update!

Honza

This revision is now accepted and ready to land.Mar 31 2020, 10:37 AM

Closed by commit rMOZILLACENTRAL5431843c523d: Bug 1566780 - Added another filter frame type for viewing control frames… (authored by Kish). · Explain WhyMar 31 2020, 10:41 AM

This revision was automatically updated to reflect the committed changes.

Kish added a commit: rMOZILLACENTRAL5431843c523d: Bug 1566780 - Added another filter frame type for viewing control frames….

Revision Contents
Changeset List

Path

Size

devtools/

client/

locales/

en-US/

netmonitor.properties

8 lines

netmonitor/

src/

actions/

12 lines

components/

websockets/

FrameFilterMenu.js

39 lines

13 lines

1 line

reducers/

15 lines

selectors/

23 lines

test/

browser_net_ws-early-connection.js

2 lines

Diff 252806

devtools/client/locales/en-US/netmonitor.properties

Loading...

devtools/client/netmonitor/src/actions/web-sockets.js

Loading...

devtools/client/netmonitor/src/components/websockets/FrameFilterMenu.js

Loading...

devtools/client/netmonitor/src/components/websockets/Toolbar.js

Loading...

devtools/client/netmonitor/src/constants.js

Loading...

devtools/client/netmonitor/src/reducers/web-sockets.js

Loading...

devtools/client/netmonitor/src/selectors/web-sockets.js

Loading...

devtools/client/netmonitor/test/browser_net_ws-early-connection.js

Loading...