Page MenuHomePhabricator

WIP: Bug 1958853 - Render unknown MathML elements as an mrow.
Changes PlannedPublicDraft

Authored by emilio on Apr 7 2025, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 13 2025, 2:26 PM
Unknown Object (File)
Oct 10 2025, 7:30 AM
Unknown Object (File)
Sep 4 2025, 5:55 AM
Unknown Object (File)
Sep 4 2025, 5:46 AM
Unknown Object (File)
Aug 30 2025, 10:09 PM
Unknown Object (File)
Aug 24 2025, 8:02 AM
Unknown Object (File)
Jul 30 2025, 10:53 AM
Unknown Object (File)
Jul 26 2025, 4:27 AM
Subscribers

Details

Reviewers
None
Bugzilla Bug ID
1958853

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default

Unit TestsUnsound

TimeTest
0 mscode-review::mercurial
WARNING: The base revision of your patch is not available in the current repository. Your patch has been rebased on central (revision None): issues may be positioned at the wrong lines.

Event Timeline

emilio created this revision.
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Apr 7 2025, 5:12 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
fredw added inline comments.
layout/base/nsCSSFrameConstructor.cpp
4665

This function is currently falling back to display property when nsCSSFrameConstructor::FindMathMLData returns nullptr: https://searchfox.org/mozilla-central/source/layout/base/nsCSSFrameConstructor.cpp#51327

Probably for all known MathML elements in https://w3c.github.io/mathml-core/#mathml-elements-and-attributes that are not listed in sMathMLData yet, we should continue to return nullptr to keep the same behavior. That includes mtable/mtd/mtr at least.