Add flag for Edit menu metrics
Change-Id: If07ffa7275823f8cb2be9277fc23847f38bb6abc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4357723
Commit-Queue: Olivier Robin <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1119880}
diff --git a/ios/chrome/browser/flags/about_flags.mm b/ios/chrome/browser/flags/about_flags.mm
index ef2c74c0..5152b6e9 100644
--- a/ios/chrome/browser/flags/about_flags.mm
+++ b/ios/chrome/browser/flags/about_flags.mm
@@ -1470,6 +1470,10 @@
flag_descriptions::kIndicateIdentityErrorInOverflowMenuName,
flag_descriptions::kIndicateIdentityErrorInOverflowMenuDescription,
flags_ui::kOsIos, FEATURE_VALUE_TYPE(kIndicateSyncErrorInOverflowMenu)},
+ {"ios-browser-edit-menu-metrics",
+ flag_descriptions::kIOSBrowserEditMenuMetricsName,
+ flag_descriptions::kIOSBrowserEditMenuMetricsDescription, flags_ui::kOsIos,
+ FEATURE_VALUE_TYPE(kIOSBrowserEditMenuMetrics)},
};
bool SkipConditionalFeatureEntry(const flags_ui::FeatureEntry& entry) {
diff --git a/ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc b/ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
index 0ce8d1b..ab04959 100644
--- a/ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
+++ b/ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
@@ -492,6 +492,10 @@
"an individual promotion causes that promotion but no other promotions to "
"occur.";
+const char kIOSBrowserEditMenuMetricsName[] = "Browser edit menu metrics";
+const char kIOSBrowserEditMenuMetricsDescription[] =
+ "Collect metrics for edit menu usage.";
+
const char kIOSCustomBrowserEditMenuName[] = "Custom browser edit menu";
const char kIOSCustomBrowserEditMenuDescription[] =
"Use the new API for the WKWebView Edit menu.";
diff --git a/ios/chrome/browser/flags/ios_chrome_flag_descriptions.h b/ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
index 278611d..0af11fa 100644
--- a/ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
+++ b/ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
@@ -421,6 +421,11 @@
extern const char kInProductHelpDemoModeName[];
extern const char kInProductHelpDemoModeDescription[];
+// Title and description for the flag to enable metrics collection for edit
+// menu.
+extern const char kIOSBrowserEditMenuMetricsName[];
+extern const char kIOSBrowserEditMenuMetricsDescription[];
+
// Title and description for the flag to enable new API for browser edit menu.
extern const char kIOSCustomBrowserEditMenuName[];
extern const char kIOSCustomBrowserEditMenuDescription[];
diff --git a/ios/chrome/browser/shared/public/features/features.cc b/ios/chrome/browser/shared/public/features/features.cc
index b7ec705..24a62e4 100644
--- a/ios/chrome/browser/shared/public/features/features.cc
+++ b/ios/chrome/browser/shared/public/features/features.cc
@@ -48,6 +48,10 @@
"DefaultBrowserIntentsShowSettings",
base::FEATURE_ENABLED_BY_DEFAULT);
+BASE_FEATURE(kIOSBrowserEditMenuMetrics,
+ "IOSBrowserEditMenuMetrics",
+ base::FEATURE_DISABLED_BY_DEFAULT);
+
BASE_FEATURE(kIOSCustomBrowserEditMenu,
"IOSCustomBrowserEditMenu",
base::FEATURE_DISABLED_BY_DEFAULT);
diff --git a/ios/chrome/browser/shared/public/features/features.h b/ios/chrome/browser/shared/public/features/features.h
index 6541808..31bd26e6 100644
--- a/ios/chrome/browser/shared/public/features/features.h
+++ b/ios/chrome/browser/shared/public/features/features.h
@@ -47,6 +47,9 @@
// Feature flag that allows external apps to show default browser settings.
BASE_DECLARE_FEATURE(kDefaultBrowserIntentsShowSettings);
+// Feature flag to log metrics for the edit menu.
+BASE_DECLARE_FEATURE(kIOSBrowserEditMenuMetrics);
+
// Feature flag to use the new Edit menu API for browser view.
BASE_DECLARE_FEATURE(kIOSCustomBrowserEditMenu);
