[omnibox] Add more flag options for on device head suggest.
So that we can try out all experiment variations we're currently
running for normal and incognito mode.
Bug: 925072
Change-Id: I961c99aab1bf86c43ee87b16e0416e67300aa897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041370
Reviewed-by: Tommy Li <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Ce Chen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#739667}
diff --git a/ios/chrome/browser/flags/about_flags.mm b/ios/chrome/browser/flags/about_flags.mm
index 6bd7a900..1dcc3925 100644
--- a/ios/chrome/browser/flags/about_flags.mm
+++ b/ios/chrome/browser/flags/about_flags.mm
@@ -138,12 +138,56 @@
const FeatureEntry::FeatureParam kOmniboxOnDeviceHeadSuggestIncognitoOnly[] = {
{OmniboxFieldTrial::kOnDeviceHeadSuggestIncognitoServeMode,
"incognito-only"}};
+const FeatureEntry::FeatureParam kOmniboxOnDeviceHeadSuggestRelevance1000[] = {
+ {OmniboxFieldTrial::kOnDeviceHeadSuggestMaxScoreForNonUrlInput, "1000"},
+ {OmniboxFieldTrial::kOnDeviceHeadSuggestDemoteMode, "decrease-relevances"}};
+const FeatureEntry::FeatureParam
+ kOmniboxOnDeviceHeadSuggestIncognitoOnlyRelevance1000[] = {
+ {OmniboxFieldTrial::kOnDeviceHeadSuggestIncognitoServeMode,
+ "incognito-only"},
+ {OmniboxFieldTrial::kOnDeviceHeadSuggestMaxScoreForNonUrlInput,
+ "1000"}};
+const FeatureEntry::FeatureParam kOmniboxOnDeviceHeadSuggestDelay200Ms[] = {
+ {OmniboxFieldTrial::kOnDeviceHeadSuggestDelaySuggestRequestMs, "200"}};
+const FeatureEntry::FeatureParam kOmniboxOnDeviceHeadSuggestDelay350Ms[] = {
+ {OmniboxFieldTrial::kOnDeviceHeadSuggestDelaySuggestRequestMs, "350"}};
+const FeatureEntry::FeatureParam
+ kOmniboxOnDeviceHeadSuggestDelay200MsAndRelevance1000[] = {
+ {OmniboxFieldTrial::kOnDeviceHeadSuggestDelaySuggestRequestMs, "200"},
+ {OmniboxFieldTrial::kOnDeviceHeadSuggestMaxScoreForNonUrlInput, "1000"},
+ {OmniboxFieldTrial::kOnDeviceHeadSuggestDemoteMode,
+ "decrease-relevances"}};
+const FeatureEntry::FeatureParam
+ kOmniboxOnDeviceHeadSuggestDelay350MsAndRelevance1000[] = {
+ {OmniboxFieldTrial::kOnDeviceHeadSuggestDelaySuggestRequestMs, "350"},
+ {OmniboxFieldTrial::kOnDeviceHeadSuggestMaxScoreForNonUrlInput, "1000"},
+ {OmniboxFieldTrial::kOnDeviceHeadSuggestDemoteMode,
+ "decrease-relevances"}};
+
const FeatureEntry::FeatureVariation
- kOmniboxOnDeviceHeadSuggestIncognitoVariations[] = {
+ kOmniboxOnDeviceHeadSuggestExperimentVariations[] = {
{"both-normal-and-incognito", kOmniboxOnDeviceHeadSuggestAlwaysServe,
base::size(kOmniboxOnDeviceHeadSuggestAlwaysServe), nullptr},
{"incognito-only", kOmniboxOnDeviceHeadSuggestIncognitoOnly,
- base::size(kOmniboxOnDeviceHeadSuggestIncognitoOnly), nullptr}};
+ base::size(kOmniboxOnDeviceHeadSuggestIncognitoOnly), nullptr},
+ {"relevance-1000", kOmniboxOnDeviceHeadSuggestRelevance1000,
+ base::size(kOmniboxOnDeviceHeadSuggestRelevance1000), nullptr},
+ {"incognito-only-relevance-1000",
+ kOmniboxOnDeviceHeadSuggestIncognitoOnlyRelevance1000,
+ base::size(kOmniboxOnDeviceHeadSuggestIncognitoOnlyRelevance1000),
+ nullptr},
+ {"request-delay-200ms", kOmniboxOnDeviceHeadSuggestDelay200Ms,
+ base::size(kOmniboxOnDeviceHeadSuggestDelay200Ms), nullptr},
+ {"request-delay-350ms", kOmniboxOnDeviceHeadSuggestDelay350Ms,
+ base::size(kOmniboxOnDeviceHeadSuggestDelay350Ms), nullptr},
+ {"delay-200ms-relevance-1000",
+ kOmniboxOnDeviceHeadSuggestDelay200MsAndRelevance1000,
+ base::size(kOmniboxOnDeviceHeadSuggestDelay200MsAndRelevance1000),
+ nullptr},
+ {"delay-350ms-relevance-1000",
+ kOmniboxOnDeviceHeadSuggestDelay350MsAndRelevance1000,
+ base::size(kOmniboxOnDeviceHeadSuggestDelay350MsAndRelevance1000),
+ nullptr}};
const FeatureEntry::FeatureParam kOmniboxUIMaxAutocompleteMatches3[] = {
{OmniboxFieldTrial::kUIMaxAutocompleteMatchesParam, "3"}};
@@ -378,7 +422,7 @@
flags_ui::kOsIos,
FEATURE_WITH_PARAMS_VALUE_TYPE(
omnibox::kOnDeviceHeadProvider,
- kOmniboxOnDeviceHeadSuggestIncognitoVariations,
+ kOmniboxOnDeviceHeadSuggestExperimentVariations,
"OmniboxOnDeviceHeadSuggestIOS")},
{"omnibox-ui-max-autocomplete-matches",
flag_descriptions::kOmniboxUIMaxAutocompleteMatchesName,
