[iOS] Rename NTP field trial to shuffle ablation groups
Renames NTP field trials from "NewTabPageRetention" to
"NewTabPageFieldTrials" to generalize them, allowing other NTP
experiments to be included in the future. This also shuffles all the
users which we want for the tile ablation experiment in M114.
Fixed: 1445967
Change-Id: I1ac447da4c89d06d7ec568dd53fd44ebe0c80bd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4537686
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Adam Arcaro <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1148056}
diff --git a/ios/chrome/browser/flags/about_flags.mm b/ios/chrome/browser/flags/about_flags.mm
index 2df4e40..ddf2fdf 100644
--- a/ios/chrome/browser/flags/about_flags.mm
+++ b/ios/chrome/browser/flags/about_flags.mm
@@ -93,7 +93,7 @@
#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_feature.h"
#import "ios/chrome/browser/ui/download/features.h"
#import "ios/chrome/browser/ui/ntp/new_tab_page_feature.h"
-#import "ios/chrome/browser/ui/ntp/new_tab_page_retention_field_trial_constants.h"
+#import "ios/chrome/browser/ui/ntp/new_tab_page_field_trial_constants.h"
#import "ios/chrome/browser/ui/omnibox/omnibox_ui_features.h"
#import "ios/chrome/browser/ui/popup_menu/overflow_menu/feature_flags.h"
#import "ios/chrome/browser/ui/post_restore_signin/features.h"
@@ -532,16 +532,17 @@
{{"minimal", kIOSNewPostRestoreExperienceMinimal,
std::size(kIOSNewPostRestoreExperienceMinimal), nullptr}};
-const FeatureEntry::FeatureParam kNewTabPageRetentionTileAblationHideAll[] = {
- {ntp_tiles::kNewTabPageRetentionParam, "1"}};
-const FeatureEntry::FeatureParam kNewTabPageRetentionTileAblationHideMVTOnly[] =
- {{ntp_tiles::kNewTabPageRetentionParam, "2"}};
-const FeatureEntry::FeatureVariation kNewTabPageRetentionVariations[] = {
- {"- Tile ablation, Hide all", kNewTabPageRetentionTileAblationHideAll,
- std::size(kNewTabPageRetentionTileAblationHideAll), nullptr},
+const FeatureEntry::FeatureParam kNewTabPageFieldTrialTileAblationHideAll[] = {
+ {ntp_tiles::kNewTabPageFieldTrialParam, "1"}};
+const FeatureEntry::FeatureParam
+ kNewTabPageFieldTrialTileAblationHideMVTOnly[] = {
+ {ntp_tiles::kNewTabPageFieldTrialParam, "2"}};
+const FeatureEntry::FeatureVariation kNewTabPageFieldTrialVariations[] = {
+ {"- Tile ablation, Hide all", kNewTabPageFieldTrialTileAblationHideAll,
+ std::size(kNewTabPageFieldTrialTileAblationHideAll), nullptr},
{"- Tile ablation, Hide MVT only",
- kNewTabPageRetentionTileAblationHideMVTOnly,
- std::size(kNewTabPageRetentionTileAblationHideMVTOnly), nullptr}};
+ kNewTabPageFieldTrialTileAblationHideMVTOnly,
+ std::size(kNewTabPageFieldTrialTileAblationHideMVTOnly), nullptr}};
const FeatureEntry::FeatureParam kEnableExpKitTextClassifierDate[] = {
{"date", "true"}};
@@ -1137,11 +1138,11 @@
flag_descriptions::kIOSPasswordBottomSheetName,
flag_descriptions::kIOSPasswordBottomSheetDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(password_manager::features::kIOSPasswordBottomSheet)},
- {"ios-new-tab-page-retention", flag_descriptions::kNewTabPageRetentionName,
- flag_descriptions::kNewTabPageRetentionDescription, flags_ui::kOsIos,
- FEATURE_WITH_PARAMS_VALUE_TYPE(ntp_tiles::kNewTabPageRetention,
- kNewTabPageRetentionVariations,
- ntp_tiles::kNewTabPageRetentionName)},
+ {"ios-new-tab-page-retention", flag_descriptions::kNewTabPageFieldTrialName,
+ flag_descriptions::kNewTabPageFieldTrialDescription, flags_ui::kOsIos,
+ FEATURE_WITH_PARAMS_VALUE_TYPE(ntp_tiles::kNewTabPageFieldTrial,
+ kNewTabPageFieldTrialVariations,
+ ntp_tiles::kNewTabPageFieldTrialName)},
{"autofill-parse-iban-fields",
flag_descriptions::kAutofillParseIBANFieldsName,
flag_descriptions::kAutofillParseIBANFieldsDescription, flags_ui::kOsIos,
