[ios] Add Parameters for Trending Queries feature
This will enable users to set the arms for this feature in
chrome://flags. The arm-specific checks are added to the model.
Bug: 1340123
Change-Id: Ib34f58e74347439011e95492f94f8c038b913c42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3774084
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1026269}
diff --git a/ios/chrome/browser/flags/about_flags.mm b/ios/chrome/browser/flags/about_flags.mm
index 311f998..5723f40b 100644
--- a/ios/chrome/browser/flags/about_flags.mm
+++ b/ios/chrome/browser/flags/about_flags.mm
@@ -397,6 +397,35 @@
std::size(kFREDefaultBrowserPromoShortDelay), nullptr},
};
+const FeatureEntry::FeatureParam kTrendingQueriesEnableAllUsers[] = {
+ {kTrendingQueriesHideShortcutsParam, "false"},
+ {kTrendingQueriesDisabledFeedParam, "false"},
+ {kTrendingQueriesSignedOutParam, "false"}};
+const FeatureEntry::FeatureParam kTrendingQueriesEnableAllUsersHideShortcuts[] =
+ {{kTrendingQueriesHideShortcutsParam, "true"},
+ {kTrendingQueriesDisabledFeedParam, "false"},
+ {kTrendingQueriesSignedOutParam, "false"}};
+const FeatureEntry::FeatureParam kTrendingQueriesEnableFeedDisabled[] = {
+ {kTrendingQueriesHideShortcutsParam, "false"},
+ {kTrendingQueriesDisabledFeedParam, "true"},
+ {kTrendingQueriesSignedOutParam, "false"}};
+const FeatureEntry::FeatureParam kTrendingQueriesEnableSignedOut[] = {
+ {kTrendingQueriesHideShortcutsParam, "true"},
+ {kTrendingQueriesDisabledFeedParam, "false"},
+ {kTrendingQueriesSignedOutParam, "true"}};
+
+const FeatureEntry::FeatureVariation kTrendingQueriesModuleVariations[] = {
+ {"Enabled All Users", kTrendingQueriesEnableAllUsers,
+ std::size(kTrendingQueriesEnableAllUsers), nullptr},
+ {"Enabled All Users Hide Shortcuts",
+ kTrendingQueriesEnableAllUsersHideShortcuts,
+ std::size(kTrendingQueriesEnableAllUsersHideShortcuts), nullptr},
+ {"Enabled Disabled Feed", kTrendingQueriesEnableFeedDisabled,
+ std::size(kTrendingQueriesEnableFeedDisabled), nullptr},
+ {"Enabled Signed Out", kTrendingQueriesEnableSignedOut,
+ std::size(kTrendingQueriesEnableSignedOut), nullptr},
+};
+
const FeatureEntry::FeatureParam kNewMICEFREWithUMADialog[] = {
{kNewMobileIdentityConsistencyFREParam,
kNewMobileIdentityConsistencyFREParamUMADialog}};
@@ -1039,7 +1068,9 @@
FEATURE_VALUE_TYPE(omnibox::kAdaptiveSuggestionsCount)},
{"trending-queries-module", flag_descriptions::kTrendingQueriesModuleName,
flag_descriptions::kTrendingQueriesModuleDescription, flags_ui::kOsIos,
- FEATURE_VALUE_TYPE(kTrendingQueriesModule)},
+ FEATURE_WITH_PARAMS_VALUE_TYPE(kTrendingQueriesModule,
+ kTrendingQueriesModuleVariations,
+ "TrendingQueriesModule")},
{"autofill-parse-iban-fields",
flag_descriptions::kAutofillParseIbanFieldsName,
flag_descriptions::kAutofillParseIbanFieldsDescription, flags_ui::kOsIos,
