[iOS] Show bookmark account storage feature flag
Make iOS bookmark account storage flag visible for testers.
Bug: 1404250
Change-Id: I6435f15a7301e700fffacf5721d9ef5a2142f79c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4288780
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Menghan Yang <[email protected]>
Reviewed-by: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1110373}
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
index 0b27eb27d..8c86190 100644
--- a/chrome/browser/flag-metadata.json
+++ b/chrome/browser/flag-metadata.json
@@ -1858,6 +1858,11 @@
"expiry_milestone": 120
},
{
+ "name": "enable-bookmarks-account-storage",
+ "owners": [ "jlebel", "bsazonov", "chrome-signin-team" ],
+ "expiry_milestone": 118
+ },
+ {
"name": "enable-cardboard",
"owners": [ "alcooper", "[email protected]"],
"expiry_milestone": 120
diff --git a/ios/chrome/browser/flags/BUILD.gn b/ios/chrome/browser/flags/BUILD.gn
index de57220..808b7fda 100644
--- a/ios/chrome/browser/flags/BUILD.gn
+++ b/ios/chrome/browser/flags/BUILD.gn
@@ -18,6 +18,7 @@
"//base",
"//components/autofill/core/common",
"//components/autofill/ios/browser",
+ "//components/bookmarks/common",
"//components/breadcrumbs/core:feature_flags",
"//components/commerce/core:feature_list",
"//components/dom_distiller/core",
diff --git a/ios/chrome/browser/flags/about_flags.mm b/ios/chrome/browser/flags/about_flags.mm
index 06b5cc8..9dea807 100644
--- a/ios/chrome/browser/flags/about_flags.mm
+++ b/ios/chrome/browser/flags/about_flags.mm
@@ -25,6 +25,7 @@
#import "components/autofill/core/common/autofill_payments_features.h"
#import "components/autofill/core/common/autofill_switches.h"
#import "components/autofill/ios/browser/autofill_switches.h"
+#import "components/bookmarks/common/bookmark_features.h"
#import "components/breadcrumbs/core/features.h"
#import "components/commerce/core/commerce_feature_list.h"
#import "components/commerce/core/flag_descriptions.h"
@@ -1392,6 +1393,11 @@
flag_descriptions::kIndicateAccountStorageErrorInAccountCellDescription,
flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kIndicateAccountStorageErrorInAccountCell)},
+ {"enable-bookmarks-account-storage",
+ flag_descriptions::kEnableBookmarksAccountStorageName,
+ flag_descriptions::kEnableBookmarksAccountStorageDescription,
+ flags_ui::kOsIos,
+ FEATURE_VALUE_TYPE(bookmarks::kEnableBookmarksAccountStorage)},
};
bool SkipConditionalFeatureEntry(const flags_ui::FeatureEntry& entry) {
diff --git a/ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc b/ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
index aaa7f89..64fed95af 100644
--- a/ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
+++ b/ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
@@ -274,6 +274,11 @@
const char kEnableAutofillAddressSavePromptDescription[] =
"Enable the Autofill address save prompts.";
+const char kEnableBookmarksAccountStorageName[] =
+ "Enable Bookmarks Account Storage";
+const char kEnableBookmarksAccountStorageDescription[] =
+ "Enable bookmarks account storage and related UI features.";
+
const char kEnableCBDSignOutName[] = "Enable Clear Browsing Data Sign-out";
const char kEnableCBDSignOutDescription[] =
"Offer signed-in user to sign-out from Clear Browsing Data settings.";
diff --git a/ios/chrome/browser/flags/ios_chrome_flag_descriptions.h b/ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
index fd1894c..baf613f 100644
--- a/ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
+++ b/ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
@@ -206,6 +206,11 @@
extern const char kDetectMainThreadFreezeName[];
extern const char kDetectMainThreadFreezeDescription[];
+// Title and description for the flag to enable the bookmarks account storage
+// and related UI features.
+extern const char kEnableBookmarksAccountStorageName[];
+extern const char kEnableBookmarksAccountStorageDescription[];
+
// Title and description for the flag to enable checking feed visibility on
// attention log start.
extern const char kEnableCheckVisibilityOnAttentionLogStartName[];
