Mass-migrate users of base::ThreadPool() as a trait to base::ThreadPool:: API [chrome/]
Split chrome/ from
https://chromium-review.googlesource.com/c/chromium/src/+/2026350
as it had trouble landing in one go.
The following script was used to generate this CL (run on every C++
file in the codebase; processing .h before matching .cc/.mm):
https://bugs.chromium.org/p/chromium/issues/detail?id=1026641#c22
(intentionally ignores cleaning post_task.h for now).
[email protected]
Bug: 1026641
Change-Id: I3236dcea6d072ecb395c39983b29cee61f15ede3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075077
Reviewed-by: Gabriel Charette <[email protected]>
Reviewed-by: François Doray <[email protected]>
Commit-Queue: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/heads/master@{#744835}
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index 45f3c99..1d84022 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -27,6 +27,7 @@
#include "base/synchronization/waitable_event.h"
#include "base/task/post_task.h"
#include "base/task/task_traits.h"
+#include "base/task/thread_pool.h"
#include "base/threading/thread.h"
#include "base/threading/thread_restrictions.h"
#include "base/threading/thread_task_runner_handle.h"
@@ -1286,16 +1287,14 @@
// Runner for tasks critical for user experience.
scoped_refptr<base::SequencedTaskRunner> blocking_task_runner(
- base::CreateSequencedTaskRunner(
- {base::ThreadPool(), base::MayBlock(),
- base::TaskPriority::USER_BLOCKING,
+ base::ThreadPool::CreateSequencedTaskRunner(
+ {base::MayBlock(), base::TaskPriority::USER_BLOCKING,
base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN}));
// Runner for tasks that do not influence user experience.
scoped_refptr<base::SequencedTaskRunner> background_task_runner(
- base::CreateSequencedTaskRunner(
- {base::ThreadPool(), base::MayBlock(),
- base::TaskPriority::BEST_EFFORT,
+ base::ThreadPool::CreateSequencedTaskRunner(
+ {base::MayBlock(), base::TaskPriority::BEST_EFFORT,
base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN}));
base::FilePath user_data_dir;
@@ -1335,9 +1334,8 @@
base::FilePath store_path;
CHECK(base::PathService::Get(chrome::DIR_GLOBAL_GCM_STORE, &store_path));
scoped_refptr<base::SequencedTaskRunner> blocking_task_runner(
- base::CreateSequencedTaskRunner(
- {base::ThreadPool(), base::MayBlock(),
- base::TaskPriority::BEST_EFFORT,
+ base::ThreadPool::CreateSequencedTaskRunner(
+ {base::MayBlock(), base::TaskPriority::BEST_EFFORT,
base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN}));
gcm_driver_ = gcm::CreateGCMDriverDesktop(
@@ -1489,9 +1487,9 @@
if (IsRunningInBackground()) {
// upgrade_util::IsUpdatePendingRestart touches the disk, so do it on a
// suitable thread.
- base::PostTaskAndReplyWithResult(
+ base::ThreadPool::PostTaskAndReplyWithResult(
FROM_HERE,
- {base::ThreadPool(), base::TaskPriority::BEST_EFFORT,
+ {base::TaskPriority::BEST_EFFORT,
base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN, base::MayBlock()},
base::BindOnce(&upgrade_util::IsUpdatePendingRestart),
base::BindOnce(&BrowserProcessImpl::OnPendingRestartResult,
