Reland "Tab Search: Setup keyboard shortcut"
Cause of revert: The previous CL tried to add a key to
accelerators_cocoa.mm without adding to menu item
Solution: remove change in accelerators_cocoa.mm but keep the change in
global_keyboard_shortcuts_mac.mm
This is a reland of 9b3d32d9428499aabb342e5cbc350dd300a23d2a
Original change's description:
> Tab Search: Setup keyboard shortcut
>
> Setup ctrl(cmd on Mac) + shift + e as tab search keyboard shortcut
> for all desktop platforms
>
> Bug: 1099917,1112558
> Change-Id: I6c50b26714d678d0f89d2c846909ff0b802e4f0d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329944
> Commit-Queue: Yuheng Huang <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Reviewed-by: Robert Liao <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#795750}
Bug: 1099917
Bug: 1112558
Change-Id: I4639649e6b0b839ead06aac1458c058f20db5fca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343300
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Yuheng Huang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#796584}
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index af2aa93..b17423f 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -41,6 +41,7 @@
#include "chrome/browser/ui/page_info/page_info_dialog.h"
#include "chrome/browser/ui/singleton_tabs.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/ui_features.h"
#include "chrome/browser/ui/web_applications/app_browser_controller.h"
#include "chrome/browser/ui/web_applications/web_app_dialog_utils.h"
#include "chrome/browser/ui/web_applications/web_app_launch_utils.h"
@@ -379,6 +380,9 @@
case IDC_STOP:
Stop(browser_);
break;
+ case IDC_TAB_SEARCH:
+ ShowTabSearch(browser_);
+ break;
// Window management commands
case IDC_NEW_WINDOW:
@@ -1042,6 +1046,11 @@
command_updater_.UpdateCommandEnabled(IDC_WINDOW_CLOSE_OTHER_TABS,
normal_window);
+ command_updater_.UpdateCommandEnabled(
+ IDC_TAB_SEARCH, base::FeatureList::IsEnabled(features::kTabSearch) &&
+ browser_->is_type_normal() &&
+ !browser_->profile()->IsIncognitoProfile());
+
// Initialize other commands whose state changes based on various conditions.
UpdateCommandsForFullscreenMode();
UpdateCommandsForContentRestrictionState();
