Google Git
Sign in
chromium / chromium / src / 0b6d615074f7e0d10fd06c3ecc5e3faa001ae539
commit0b6d615074f7e0d10fd06c3ecc5e3faa001ae539[log] [tgz]
authorKurt Catti-Schmidt (SCHMIDT) <[email protected]>Wed Oct 14 00:02:09 2020
committerCommit Bot <[email protected]>Wed Oct 14 00:02:09 2020
tree6c01b1354028b3c67473dac61b63804820b37ec9
parent9b249e63a2aa7650aee7cefb0aaf85320a98c9c9 [diff]
[M87] More infinite loop prevention in AXPosition::AsValidDOMPosition

This is a speculative fix, as I haven't been able to reproduce this
overflow. There also is not a unit test, because I haven't been able
to reproduce this overflow by tweaking the unit test from
https://chromium-review.googlesource.com/c/chromium/src/+/2426490

However, this is still causing crashes, even after the CL 2426490 has
gone in. And all of the overflows that I've seen after that CL
loop forever in the kMoveRight scenario, so I am confident that this
change will provide the complete mitigation.

(cherry picked from commit 813c55e8bad8543395cf399c24ac2d75cf2367b9)

Bug: 1124394
Change-Id: Ife9293f2fa26a34c17d1aace03b38b3592f387d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464003
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: Kurt Catti-Schmidt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816199}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468699
Reviewed-by: Kurt Catti-Schmidt <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#352}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
1 file changed
tree: 6c01b1354028b3c67473dac61b63804820b37ec9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.