| commit | 19bf426c3222c45bddfd5dd7a46eb2a5a33a4954 | [log] [tgz] |
|---|---|---|
| author | Fabio Rocha <[email protected]> | Thu Apr 04 01:05:18 2019 |
| committer | Commit Bot <[email protected]> | Thu Apr 04 01:05:18 2019 |
| tree | 88fc92361fa360d14abdecc81d8ef6c8af739f9b | |
| parent | 37f1822beb78df94715b264b020f11b5e755e71e [diff] [blame] |
DevTools: Handle feedback shortcut when DevTools are undocked When the DevTools is undocked and focused, Alt+Shift+I does not launch the feedback dialog, leaving users who rely on this shortcut confused at times. This PR adds this capability. Besides, because showing the "chrome-devtools://" URL as feedback source would add to the confusion, we display the URL of the tab targeted by the tools instead. Change-Id: Ic4dd3bce15870ff8fd22533d055b235afb5f34e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542777 Commit-Queue: Ahmed Fakhry <[email protected]> Reviewed-by: Ahmed Fakhry <[email protected]> Reviewed-by: Michael Wasserman <[email protected]> Cr-Commit-Position: refs/heads/master@{#647569}
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc index dddd8de..fac29c30 100644 --- a/chrome/browser/ui/browser_command_controller.cc +++ b/chrome/browser/ui/browser_command_controller.cc
@@ -1210,7 +1210,8 @@ // Show various bits of UI command_updater_.UpdateCommandEnabled(IDC_DEVELOPER_MENU, show_main_ui); #if defined(GOOGLE_CHROME_BUILD) - command_updater_.UpdateCommandEnabled(IDC_FEEDBACK, show_main_ui); + command_updater_.UpdateCommandEnabled( + IDC_FEEDBACK, show_main_ui || browser_->is_devtools()); #endif UpdateShowSyncState(show_main_ui);