| commit | 274fb4cc44c4e8b6a0759934ab009e7a0efdcadb | [log] [tgz] |
|---|---|---|
| author | David Black <[email protected]> | Wed Oct 14 21:40:04 2020 |
| committer | Commit Bot <[email protected]> | Wed Oct 14 21:40:04 2020 |
| tree | 40792dba42c20d840c27411802cd6cc0a75d7f21 | |
| parent | 17ff767356e1964fc2fbc1a50d2ba9c589d18de0 [diff] |
Don't attempt to cast holding space item view during destruction. When `OnViewIsDeleting` is called, the holding space item view is already well into its destruction sequence. We shouldn't attempt to cast from `views::View` back to `HoldingSpaceItemView` at this time and we have no need to. (cherry picked from commit 974b58c842d7b20a2e5f66295565984809aa3d2a) Bug: 1137461 Change-Id: I3c431af03b692d15b4e83de25d9ffcaa2b35d148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472584 Reviewed-by: Toni Baržić <[email protected]> Commit-Queue: David Black <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#817149} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472439 Reviewed-by: David Black <[email protected]> Cr-Commit-Position: refs/branch-heads/4280@{#390} Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.