Add 'Group Tab' item to Mac context menu for Tab
Tabs are groupable if they aren't all in the same group. Otherwise, they will show as Grouped and be ungroupable.
Bug: 1039924
Change-Id: Ifff4fff3a5c4274877595912c520107a1ed5edc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026695
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Connie Wan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#737381}
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index 18f0d80..240861a 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -753,6 +753,9 @@
case IDC_WINDOW_PIN_TAB:
PinTab(browser_);
break;
+ case IDC_WINDOW_GROUP_TAB:
+ GroupTab(browser_);
+ break;
case IDC_WINDOW_CLOSE_TABS_TO_RIGHT:
CloseTabsToRight(browser_);
break;
@@ -769,6 +772,9 @@
case IDC_PIN_TARGET_TAB:
PinKeyboardFocusedTab(browser_);
break;
+ case IDC_GROUP_TARGET_TAB:
+ GroupKeyboardFocusedTab(browser_);
+ break;
case IDC_DUPLICATE_TARGET_TAB:
DuplicateKeyboardFocusedTab(browser_);
break;
@@ -1053,6 +1059,7 @@
command_updater_.UpdateCommandEnabled(IDC_WINDOW_MUTE_SITE, normal_window);
command_updater_.UpdateCommandEnabled(IDC_WINDOW_PIN_TAB, normal_window);
+ command_updater_.UpdateCommandEnabled(IDC_WINDOW_GROUP_TAB, normal_window);
command_updater_.UpdateCommandEnabled(IDC_WINDOW_CLOSE_TABS_TO_RIGHT,
normal_window);
command_updater_.UpdateCommandEnabled(IDC_WINDOW_CLOSE_OTHER_TABS,
@@ -1140,6 +1147,8 @@
!browser_->deprecated_is_app());
command_updater_.UpdateCommandEnabled(IDC_WINDOW_PIN_TAB,
!browser_->deprecated_is_app());
+ command_updater_.UpdateCommandEnabled(IDC_WINDOW_GROUP_TAB,
+ !browser_->deprecated_is_app());
command_updater_.UpdateCommandEnabled(IDC_WINDOW_CLOSE_TABS_TO_RIGHT,
CanCloseTabsToRight(browser_));
command_updater_.UpdateCommandEnabled(IDC_WINDOW_CLOSE_OTHER_TABS,
@@ -1485,6 +1494,8 @@
IDC_MUTE_TARGET_SITE, normal_window && target_index.has_value());
command_updater_.UpdateCommandEnabled(
IDC_PIN_TARGET_TAB, normal_window && target_index.has_value());
+ command_updater_.UpdateCommandEnabled(
+ IDC_GROUP_TARGET_TAB, normal_window && target_index.has_value());
}
void BrowserCommandController::AddInterstitialObservers(WebContents* contents) {
