| commit | 56bb52a4ee55781b318c5c488b6d19b8337df9a1 | [log] [tgz] |
|---|---|---|
| author | Alex Newcomer <[email protected]> | Thu Oct 15 20:02:12 2020 |
| committer | Commit Bot <[email protected]> | Thu Oct 15 20:02:12 2020 |
| tree | 69f614d515df883f9853e978b637dbb3f3f26a71 | |
| parent | 453e7d2b4ef7ec6bcfda81f0c597f78d4654384c [diff] |
cros: Fix crash on multiprofile switch If the profile being left had a folder, we kept a reference to that folder in AppListModel's ScopedObserverList. But when profiles are swapped, we delete everything in the AppListModel::top_level_item_list_. This means the folder is deleted. Remove the item from the ScopedObserverList if it is a folder. (cherry picked from commit fb3b013d94f236594313e6e4db1f0abbbed35804) Bug: 1130901 Change-Id: I1d6ab268739f81904debcc4654e5663ddf768013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464151 Commit-Queue: Alex Newcomer <[email protected]> Reviewed-by: Xiyuan Xia <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#816300} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466668 Reviewed-by: Alex Newcomer <[email protected]> Cr-Commit-Position: refs/branch-heads/4280@{#425} Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.