Google Git
Sign in
chromium / chromium / src / 4528444c43cb53a93043abac800aace2bd0565a0
commit4528444c43cb53a93043abac800aace2bd0565a0[log] [tgz]
authorCarlos IL <[email protected]>Sat Oct 17 01:21:59 2020
committerCommit Bot <[email protected]>Sat Oct 17 01:21:59 2020
tree9921659d7021a147ee4fd64d586dc2f627c27f67
parente7224346db628a05dd16e2b6bbcc513f75011907 [diff]
Show mixed form warning for mixed forms that submit to new tab

Previously forms on secure sites that submit to an insecure target, but
that submitted on a new tab (with target=_blank) showed the on form
warning but not the on-submit one. This CL fixes it.

Pending work: Like other interstitials for navigations on new tabs,
this will go back to the NTP if Go Back is selected, it might make
more sense to close the new tab in this case, but in the interest of
keeping the CL simple for merging, this will be done on a separate CL,
which won't be merged.

Bug: 1134466
Change-Id: I6169fef6bd368f9c8ca054d7bbd8f96e50490956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451549
Commit-Queue: Carlos IL <[email protected]>
Commit-Queue: Emily Stark <[email protected]>
Reviewed-by: Emily Stark <[email protected]>
Auto-Submit: Carlos IL <[email protected]>
Cr-Commit-Position: refs/heads/master@{#814059}
(cherry picked from commit 2f64d2afed25c2a549874342e2186f4447253312)

TBR: [email protected]
Change-Id: I6169fef6bd368f9c8ca054d7bbd8f96e50490956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482324
Commit-Queue: Carlos IL <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#459}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
3 files changed
tree: 9921659d7021a147ee4fd64d586dc2f627c27f67
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.