| commit | 4c32470add0b628ad3859f3983adae0865fe79bd | [log] [tgz] |
|---|---|---|
| author | Tina Wang <[email protected]> | Thu Apr 25 18:35:15 2019 |
| committer | Commit Bot <[email protected]> | Thu Apr 25 18:35:15 2019 |
| tree | 5dc762723a4da7e61d2cb53c2cd40fef78f94e40 | |
| parent | 2ba607d58c1476513dbd85d667d43e68618653a6 [diff] [blame] |
[SendTabToSelf] Add omnibox icon animation - The icon will slides in with "Send" label when the valid url is highlighted at the first time. - The icon will slides out and remain an icon to the right side of the omnibox. - The icon will remain if the url is valid, even after the sharing action of the user. Bug: 950388 Change-Id: Icbe7bc5806d6bc8e38c62a8eba9794b2900db16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555501 Commit-Queue: Tina Wang <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Reviewed-by: sebsg <[email protected]> Reviewed-by: Tommy Li <[email protected]> Cr-Commit-Position: refs/heads/master@{#654120}
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc index 378a33d..517c4fd 100644 --- a/chrome/browser/ui/browser_command_controller.cc +++ b/chrome/browser/ui/browser_command_controller.cc
@@ -509,6 +509,10 @@ case IDC_MANAGE_PASSWORDS_FOR_PAGE: ManagePasswordsForPage(browser_); break; + case IDC_SEND_TAB_TO_SELF: + // TODO(crbug/950388): add implementation. + NOTIMPLEMENTED(); + break; // Clipboard commands case IDC_CUT: