Google Git
Sign in
chromium / chromium / src / 4fa73da3c70891479ea91b5acd208e2d4cf9ce8f
commit4fa73da3c70891479ea91b5acd208e2d4cf9ce8f[log] [tgz]
authorMei Liang <[email protected]>Mon Oct 12 22:27:02 2020
committerCommit Bot <[email protected]>Mon Oct 12 22:27:02 2020
treeed10cb8c183e4605e0fdc857ac14d931a58c9349
parent2de3d5c5ce06a69ba8a5eb8c3fb22b94d5a47c41 [diff]
Avoid TabGroupModelFilter casting exception(2)

This is a follow up of crrev.com/c/2442479. This CL early returns when
TabModelFilterProvider().getTabModelFilter() is not a
TabGroupModelFilter to avoid the casting exception in
TabGroupUiCoordinator.recordSessionCount().

This CL is gated by Finch parameter "enable_launch_polish" under flag
"enable-tab-grid-layout", with gate function
TabUiFeatureUtilities#isLaunchPolishEnabled.

(cherry picked from commit 8dbcfb66710c833bcf92998a60219141c060e344)

Bug: 1133922
Change-Id: I830b6721e15b6ca558e79b66dcd7a1b783186f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443395
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Commit-Queue: Mei Liang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812903}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466163
Reviewed-by: Mei Liang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#283}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
1 file changed
tree: ed10cb8c183e4605e0fdc857ac14d931a58c9349
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.