[XProto] Remove usage of XRRUpdateConfiguration and XRandR
Since we never initialize the libxrandr (by calling XRRQueryVersion),
Xlib cannot decode the incoming randr notify events. This causes a
crash in XRRUpdateConfiguration.
This CL solves the issue by removing all calls to
XRRUpdateConfiguration, which updates the XDisplay screen dimensions.
This data is only used in the following APIs:
XDisplayWidth
XDisplayHeight
XDisplayCells
XDisplayWidthMM
XDisplayHeightMM
XWidthOfScreen
XHeightOfScreen
XWidthMMOfScreen
XHeightMMOfScreen
DisplayWidth
DisplayHeight
DisplayCells
DisplayWidthMM
DisplayHeightMM
WidthOfScreen
HeightOfScreen
WidthMMOfScreen
HeightMMOfScreen
Therefore, this CL also adds a PRESUBMIT check to ensure they aren't
being used.
Since this is the last usage of libxrandr, the build config for it is
removed.
R=nickdiego,sky
Bug: 1102059
Change-Id: Ib60811259ae23ffa8af9c50e0bb3d4ac2158e5af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285068
Commit-Queue: Thomas Anderson <[email protected]>
Reviewed-by: Nick Yamane <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Lambros Lambrou <[email protected]>
Cr-Commit-Position: refs/heads/master@{#786148}
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index ec49d8c..96bb0b2b 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -453,6 +453,14 @@
),
),
(
+ r'/\WX?(((Width|Height)(MM)?OfScreen)|(Display(Width|Height)))\(',
+ (
+ 'Use the corresponding fields in x11::Screen instead.',
+ ),
+ True,
+ (),
+ ),
+ (
r'/XInternAtom|xcb_intern_atom',
(
'Use gfx::GetAtom() instead of interning atoms directly.',
