commit | 79d284b8d22ac008b10fcdf039e8706a3b22e35f | [log] [tgz] |
---|---|---|
author | Jesse McKenna <[email protected]> | Thu Apr 23 14:51:50 2020 |
committer | Commit Bot <[email protected]> | Thu Apr 23 14:51:50 2020 |
tree | e80f70c2c6bfea0fcf000897b4915be7c98bb034 | |
parent | c71eaf362a54c4164288fd9ffc8e76d5d57c96a6 [diff] |
Reland "boilerplate.py: Ignore current-dir prefixes .\, ./" This reverts commit f909a6a231ec78eb10f433f0599d4053ab02b73e. Reason for revert: _RemoveCurrentDirectoryPrefix was missing a line to return the original argument if it was not modified, i.e. the function was returning None if no modification took place. This reland adds the missing return statement. Original change's description: > Revert "boilerplate.py: Ignore current-dir prefixes .\, ./" > > This reverts commit 9d14b9ec3607ce5cc9a9f88ddf55e39378742515. > > Reason for revert: Change is breaking calls without .\ prefix. > > Original change's description: > > boilerplate.py: Ignore current-dir prefixes .\, ./ > > > > This change makes boilerplate.py trim a leading ".\" (Windows's > > current-directory prefix) or "./" (Unix's current-directory prefix) > > from the filename argument, if present. > > > > This is a convenience change for cases where the current-directory > > prefix is prepended. For example, Windows PowerShell automatically > > prepends ".\" to a path when tab completion is used (e.g., typing > > "chrome/b" and pressing tab results in ".\chrome\browser"). This > > change will remove artifacts of this for users who use tab completion > > while typing the filename argument. > > > > Currently: > > `tools/boilerplate.py .\test.h` produces include guard `__TEST_H_` > > `tools/boilerplate.py ./test.cc` or `.mm` produces `#include "./test.h"` > > > > With this change: > > `tools/boilerplate.py .\test.h` produces include guard `TEST_H_` > > `tools/boilerplate.py ./test.cc` or `.mm` produces `#include "test.h"` > > > > Change-Id: I19fd2e72c58135b5e87d4a1e22ec8bc76ef326aa > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157876 > > Commit-Queue: Jesse McKenna <[email protected]> > > Reviewed-by: Robert Sesek <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#761085} > > [email protected],[email protected] > > Change-Id: Ic02537133fd1548f5279ead83abb0492d6657aaa > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159993 > Reviewed-by: Jesse McKenna <[email protected]> > Commit-Queue: Jesse McKenna <[email protected]> > Cr-Commit-Position: refs/heads/master@{#761185} Change-Id: Iaef7fdecaff8ae205fd0c242777676bbffb788a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161895 Auto-Submit: Jesse McKenna <[email protected]> Reviewed-by: Robert Sesek <[email protected]> Commit-Queue: Robert Sesek <[email protected]> Cr-Commit-Position: refs/heads/master@{#761923}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.