| commit | 80be2ad27bcf7d779ad528030ca44fa21deb3d52 | [log] [tgz] |
|---|---|---|
| author | Jeffrey Cohen <[email protected]> | Mon Oct 12 22:17:52 2020 |
| committer | Commit Bot <[email protected]> | Mon Oct 12 22:17:52 2020 |
| tree | 0290e5ad57042a860de1d8f3e3bb9938c4dafe7d | |
| parent | cdacdcfd043e92778830bd5d33a210c50d177ef1 [diff] |
[Screenshots] add histograms upstream for clank screenshot feature Downstream CL https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3314008 Bug: 1093386 Change-Id: I03a48bfc29cdb2ccdaae4e854cc08dc39b2ca3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451570 Reviewed-by: Ilya Sherman <[email protected]> Reviewed-by: Kristi Park <[email protected]> Commit-Queue: Jeffrey Cohen <[email protected]> Cr-Commit-Position: refs/heads/master@{#815421} (cherry picked from commit b4b03cb8f00cc647f082dcaeee8fb656423c2962) tbr: [email protected] Change-Id: I03a48bfc29cdb2ccdaae4e854cc08dc39b2ca3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466202 Reviewed-by: Jeffrey Cohen <[email protected]> Commit-Queue: Jeffrey Cohen <[email protected]> Cr-Commit-Position: refs/branch-heads/4280@{#281} Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml index 9e72438..b5f5663 100644 --- a/tools/metrics/histograms/enums.xml +++ b/tools/metrics/histograms/enums.xml
@@ -65584,12 +65584,12 @@ </int> </enum> +<enum name="SharingActionSource"> <!-- SharingActionSource must be kept in sync with ValidSharingActionSource defined in //ui/file_manager/file_manager/foreground/js/file_manager_commands.js. --> -<enum name="SharingActionSource"> <int value="0" label="Unknown"/> <int value="1" label="Context Menu"/> <int value="2" label="Share Button"/> @@ -65668,6 +65668,29 @@ <int value="7" label="Failure: decoded image draws nothing"/> </enum> +<enum name="SharingScreenshotAction"> +<!-- + SharingScreenshotAction must be kept in sync with SharingScreenshotAction defined + in /clank/browser/image_editor/internal/java/src/org/chromium/chrome/browser/image_editor/ImageEditorMetrics.java +--> + + <int value="0" label="Crop tool selected"/> + <int value="1" label="Text tool selected"/> + <int value="2" label="Draw tool selected"/> + <int value="3" label="Share sheet selected"/> + <int value="4" label="Screenshot Shared"/> + <int value="5" label="Screenshot Saved"/> + <int value="6" label="Screenshot Deleted"/> + <int value="7" label="Text tool: text edited"/> + <int value="8" label="Text tool: text copied"/> + <int value="9" label="Text tool: text scaled"/> + <int value="10" label="Text tool: text rotated"/> + <int value="11" label="Text tool: text deleted"/> + <int value="12" label="Text tool: color changed"/> + <int value="13" label="Draw tool: size changed"/> + <int value="14" label="Draw tool: color changed"/> +</enum> + <enum name="SharingSendMessageResult"> <int value="0" label="Successful"/> <int value="1" label="Device is not found"/>
diff --git a/tools/metrics/histograms/histograms_xml/sharing/histograms.xml b/tools/metrics/histograms/histograms_xml/sharing/histograms.xml index 5a7059b0..b2040e85 100644 --- a/tools/metrics/histograms/histograms_xml/sharing/histograms.xml +++ b/tools/metrics/histograms/histograms_xml/sharing/histograms.xml
@@ -316,6 +316,16 @@ </summary> </histogram> +<histogram name="Sharing.Screenshot.Action" enum="SharingScreenshotAction" + expires_after="M92"> + <owner>[email protected]</owner> + <owner>[email protected]</owner> + <summary> + Logged when actions are taken in the sharing screenshot image editing + feature. + </summary> +</histogram> + <histogram name="Sharing.ScreenshotsAndroid.IsEditorDismissedOnStart" enum="Boolean" expires_after="M89"> <owner>[email protected]</owner>