Google Git
Sign in
chromium / chromium / src / 850dd74ad4b00a27171881ed09d54ed0d0a557cd
commit850dd74ad4b00a27171881ed09d54ed0d0a557cd[log] [tgz]
authorTomasz Śniatowski <[email protected]>Wed Aug 07 20:46:04 2019
committerChrome Cunningham <[email protected]>Wed Aug 07 20:46:04 2019
tree41f197c7e2e4c3f7c9db871994efa7175e9b9378
parent8cdd76f28b4d97e5a7c66e234bb3c33a80b5f1bc [diff]
[TO 77] Fix encoder/decoder typo in android media_codec_util.cc

Make MediaCodecUtil::IsHEVCDecoderAvailable call IsDecoderSupportedByDevice
instead of IsEncoderSupportedByDevice. It looks like a typo, and isn't
harmless: it can cause content shell to stall at startup if built with
enable_hevc_demuxing=true when the renderer tries to query the encoder.

Apparently it's a case of doing something in the renderer that's not
allowed, as explained in
https://chromium-review.googlesource.com/c/chromium/src/+/1694241
(which happened to add this encoder/decoder typo).

BUG=980091, 980682
TEST=build with enable_hevc_demuxing=true, run content shell apk
R=​chcunningham

Change-Id: Iaadc73e6dd4301b6e300891cbb0baf7afe8f5e63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730163
Reviewed-by: Chrome Cunningham <[email protected]>
Commit-Queue: Chrome Cunningham <[email protected]>
Cr-Commit-Position: refs/heads/master@{#684091}
(cherry picked from commit 2fb1112f69167a2b6678f7fdc9f3f3fe88587529)


TBR: [email protected]
TBR: [email protected]
Change-Id: Iaadc73e6dd4301b6e300891cbb0baf7afe8f5e63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742518
Reviewed-by: Chrome Cunningham <[email protected]>
Cr-Commit-Position: refs/branch-heads/3865@{#270}
Cr-Branched-From: 0cdcc6158160790658d1f033d3db873603250124-refs/heads/master@{#681094}
2 files changed
tree: 41f197c7e2e4c3f7c9db871994efa7175e9b9378
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .