Various upgrade_util improvements.
- upgrade_util.{cc,h} and friends are now only included in the build for
relevant platforms (desktop Chrome).
- upgrade_util::SetNewCommandLine now explicitly takes ownership of its
argument.
- A test seam has been added to RelaunchChromeBrowser. Tests may now
specify a callback to be run when relaunch takes place.
- Unexpected calls to RelaunchChromeBrowser in browser_tests and friends
now cause test failures (they previously attempted to launch Chrome).
- ScopedRelaunchChromeBrowserOverride is now available for tests of
scenarios that involved RelaunchChromeBrowser.
BUG=958893,989468
Change-Id: I8620e2bbe56e282934b94b3ea2ae52ef32f9d04a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736707
Auto-Submit: Greg Thompson <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Greg Thompson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#685466}
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index bb4b772..a68d42d 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -1458,7 +1458,7 @@
DLOG(WARNING) << "Shutting down current instance of the browser.";
chrome::AttemptExit();
- upgrade_util::SetNewCommandLine(new_cl.release());
+ upgrade_util::SetNewCommandLine(std::move(new_cl));
}
void BrowserProcessImpl::OnAutoupdateTimer() {
