Split code from SavePasswordsPreferences to ExportFlow
SavePasswordsPreferences currently contain code to handle showing
stored passwords, searching in them, and also exporting them.
While searching passwords is tighly coupled with displaying them,
exporting has nothing in common with displaying, apart from handling
the same data.
To make the classes more focused and reasonably sized, this CL splits
the explort flow UX logic from SavePasswordsPreferences.java to a new
class, ExportFlow.java.
The Espresso tests for export remain part of
SavePasswordsPreferencesTest.java, because from the user point of view
nothing changes and the export flow is still part of the functionality
offered on the settings page provided by SavePasswordsPreferences. Not
changing the tests during a refactoring also ensures that no
unintentional behaviour was introduced.
Bug: 810016
Change-Id: I90e1a5b62f3a3ed7573d62fcf97d49519cbfc074
Reviewed-on: https://chromium-review.googlesource.com/973205
Commit-Queue: Vaclav Brozek <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#545150}diff --git a/chrome/android/java_sources.gni b/chrome/android/java_sources.gni
index 831035d..41459366e 100644
--- a/chrome/android/java_sources.gni
+++ b/chrome/android/java_sources.gni
@@ -1007,6 +1007,7 @@
"java/src/org/chromium/chrome/browser/preferences/password/CallbackDelayer.java",
"java/src/org/chromium/chrome/browser/preferences/password/DialogManager.java",
"java/src/org/chromium/chrome/browser/preferences/password/ExportErrorDialogFragment.java",
+ "java/src/org/chromium/chrome/browser/preferences/password/ExportFlow.java",
"java/src/org/chromium/chrome/browser/preferences/password/ExportWarningDialogFragment.java",
"java/src/org/chromium/chrome/browser/preferences/password/ManualCallbackDelayer.java",
"java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java",
