Google Git
Sign in
chromium / chromium / src / 9cef9129736882fbeb922f6e1ac131d5e5415e9c
commit9cef9129736882fbeb922f6e1ac131d5e5415e9c[log] [tgz]
authorMehran Mahmoudi <[email protected]>Mon Oct 19 16:19:32 2020
committerMehran Mahmoudi <[email protected]>Mon Oct 19 16:19:32 2020
tree196fade26aa56aa843efe9e129a61c6233619cd2
parentb4ad5a5197f060986277fc9470a1cb83575a8ea6 [diff]
[M87 Merge] [Paint Preview] Refactor player integeration + core player callback interface

This CL cleans up the player integeration logic with Chrome, which mostly
lived in TabbedPaintPreviewPlayer. That class is now divided in two:
One is responsible of showing a paint preview in a tab, and the other controls
the logic related to the show-on-startup experiment.

This CL also gets rid of most of the logic related to the demo mode. Demo mode
now also uses the TabbedPaintPreview for displaying a paint preview.

Finally, this CL organizes the various callbacks that PlayerManager needs into
one interface.


(cherry picked from commit f7fb04eca368c9bcce33c46a3119c9da2ecb1732)

Bug: 1132451
Change-Id: I748b6bb43d78d174c1a4f79ce8f4325cd2970e2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432752
Commit-Queue: Mehran Mahmoudi <[email protected]>
Auto-Submit: Mehran Mahmoudi <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815633}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485771
Reviewed-by: Mehran Mahmoudi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#490}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
36 files changed
tree: 196fade26aa56aa843efe9e129a61c6233619cd2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.