Google Git
Sign in
chromium / chromium / src / 75a35135a84f24cee7cbf1f1af4e8c7f8db079c2
commit75a35135a84f24cee7cbf1f1af4e8c7f8db079c2[log] [tgz]
authorXinghui Lu <[email protected]>Tue Oct 13 01:21:02 2020
committerCommit Bot <[email protected]>Tue Oct 13 01:21:02 2020
tree7c02a1820d11fa6bd6e480cea59c0a3dfe33d6a9
parent42fd10e62bb0e62f107bc71f547f24dd48bcdd5d [diff]
[M87] Log metrics when ESB message is shown or opened in interstitials.

Add two new enum values in MetricsHelper::Interaction:
SHOW_ENHANCED_PROTECTION
OPEN_ENHANCED_PROTECTION

SHOW_ENHANCED_PROTECTION is logged when the enhanced protection message
is shown in the interstitial. OPEN_ENHANCED_PROTECTION is logged when
the enhanced protection link is clicked. We can get the engagement rate
of this new UI from the new enum values.

(cherry picked from commit 4d0e4b9b50d7267e7c6582ac36b30e0417460416)

Bug: 1130721
Change-Id: Iecd0a08eaac1b1448bbe6a43a9c8290e27b1be18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459073
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815782}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466214
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#299}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
8 files changed
tree: 7c02a1820d11fa6bd6e480cea59c0a3dfe33d6a9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.