[omnibox] Reduced number of parameters to ACInput constructor
Most of AutocompleteInput's constructor's parameters are not needed in
the constructor. This CL removes all but the necessary ones and
provides setters for the remainder. It also changes all the call sites.
Bug: 701146
Change-Id: I99911d47bec8b3286f9bf9bd2b822aeb315f4005
Reviewed-on: https://chromium-review.googlesource.com/667396
Commit-Queue: Kevin Bailey <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Cr-Commit-Position: refs/heads/master@{#505524}diff --git a/components/omnibox/browser/zero_suggest_provider.cc b/components/omnibox/browser/zero_suggest_provider.cc
index a6ca8a9..68ac5eb 100644
--- a/components/omnibox/browser/zero_suggest_provider.cc
+++ b/components/omnibox/browser/zero_suggest_provider.cc
@@ -284,10 +284,13 @@
const AutocompleteInput ZeroSuggestProvider::GetInput(bool is_keyword) const {
// The callers of this method won't look at the AutocompleteInput's
// |from_omnibox_focus| member, so we can set its value to false.
- return AutocompleteInput(base::string16(), base::string16::npos,
- std::string(), GURL(current_query_), current_title_,
- current_page_classification_, true, false, false,
- true, false, client()->GetSchemeClassifier());
+ AutocompleteInput input(base::string16(), current_page_classification_,
+ client()->GetSchemeClassifier());
+ input.set_current_url(GURL(current_query_));
+ input.set_current_title(current_title_);
+ input.set_prevent_inline_autocomplete(true);
+ input.set_allow_exact_keyword_match(false);
+ return input;
}
bool ZeroSuggestProvider::ShouldAppendExtraParams(
