Update Code Review docs for launch and Owners-Override
Change-Id: I86f61d876351b7f5b46899bcce1453f9693e2de0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2819958
Auto-Submit: Jason Clinton <[email protected]>
Commit-Queue: Jason Clinton <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/heads/master@{#874374}
diff --git a/docs/code_reviews.md b/docs/code_reviews.md
index fb376c7..a6a7ab1 100644
--- a/docs/code_reviews.md
+++ b/docs/code_reviews.md
@@ -4,9 +4,9 @@
All change lists (CLs) must be reviewed.
The general patch, upload, and land process is covered in more detail in the
-[contributing code](contributing.md) page. To learn about upcoming code review
-and OWNERS policy changes, see
-[Mandatory code review and OWNERS](code_review_owners.md).
+[contributing code](contributing.md) page. To learn about the code review changes
+and OWNERS policy changes launched on March 24, 2021, see
+[Mandatory Code Review and Native OWNERS](code_review_owners.md).
# Code review policies
@@ -55,7 +55,7 @@
More detail on the owners file format is provided [here](#owners-file-details).
*Tip:* The `git cl owners` command can help find owners. Gerrit also provides
-this functionality via the `Find Owners` button on CLs.
+this functionality in the Reviewers field of CLs.
While owners must approve all patches, any committer can contribute to the
review. In some directories the owners can be overloaded or there might be
@@ -170,7 +170,8 @@
Setting the `Owners-Override +1` label will bypass OWNERS enforcement. Active
[sheriffs](sheriffs.md), [Large Scale Changes](#large-scale-changes) and
-[Global Approvers](#global-approvals) reviewers have this capability.
+[Global Approvers](#global-approvals) reviewers, and Release Program Managers
+have this capability.
## Mechanical changes
@@ -205,7 +206,11 @@
effectively revert and reland on their own.
Rubber Stamper never provides OWNERS approval, by design. It's intended to be
-used by those who have owners in the directory modified or who are sheriffs.
+used by those who have owners in the directory modified or who are sheriffs. If
+it provided both code review and OWNERS approval, that would be an abuse vector:
+that would allow anyone who can create a revert or cherry-pick to land it
+without any other person being involved (e.g. the silent revert of security
+patches).
-Changes not supported by `Rubber Stamper` still need a +1 from another
+Changes not supported by `Rubber Stamper` always need a +1 from another
committer.
