Remove expired flags: enable-desktop-pwas and enable-experimental-app-banners
This CL removes two flags:
- enable-desktop-pwas: This is on by default for desktop.
- enable-experimental-app-banners: This is on by default for Android
These flags are being removed together because
AppBannerManager::IsExperimentalAppBannersEnabled() was true if either
one was true. This was in effect true for all platforms by default.
TBR: [email protected]
Bug: 959086
Change-Id: I0c9f170f3be7ba1cacc7750c9268316912c98ff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609744
Commit-Queue: Alan Cutter <[email protected]>
Reviewed-by: Ben Wells <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: Azeem Arshad <[email protected]>
Reviewed-by: Adrienne Porter Felt <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#662060}
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index cc19ed91..00435dec 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -973,17 +973,14 @@
command_updater_.UpdateCommandEnabled(IDC_HOME,
normal_window || browser_->is_app());
- const bool is_experimental_hosted_app =
- web_app::AppBrowserController::IsForExperimentalWebAppBrowser(browser_);
+ const bool is_web_app =
+ web_app::AppBrowserController::IsForWebAppBrowser(browser_);
// Hosted app browser commands.
- command_updater_.UpdateCommandEnabled(IDC_COPY_URL,
- is_experimental_hosted_app);
- command_updater_.UpdateCommandEnabled(IDC_OPEN_IN_CHROME,
- is_experimental_hosted_app);
- command_updater_.UpdateCommandEnabled(IDC_SITE_SETTINGS,
- is_experimental_hosted_app);
+ command_updater_.UpdateCommandEnabled(IDC_COPY_URL, is_web_app);
+ command_updater_.UpdateCommandEnabled(IDC_OPEN_IN_CHROME, is_web_app);
+ command_updater_.UpdateCommandEnabled(IDC_SITE_SETTINGS, is_web_app);
command_updater_.UpdateCommandEnabled(IDC_HOSTED_APP_MENU_APP_INFO,
- is_experimental_hosted_app);
+ is_web_app);
// Window management commands
command_updater_.UpdateCommandEnabled(IDC_SELECT_NEXT_TAB, normal_window);
@@ -1272,7 +1269,7 @@
void BrowserCommandController::UpdateCommandsForHostedAppAvailability() {
bool has_toolbar =
browser_->is_type_tabbed() ||
- web_app::AppBrowserController::IsForExperimentalWebAppBrowser(browser_);
+ web_app::AppBrowserController::IsForWebAppBrowser(browser_);
if (window() && window()->ShouldHideUIForFullscreen())
has_toolbar = false;
command_updater_.UpdateCommandEnabled(IDC_FOCUS_TOOLBAR, has_toolbar);
