Copy Link To Text: Surround selected text with quotes
(cherry picked from commit 1c55ded397b9dbaa334410e6a18d39dcdc28ccf0)
Bug: 1105862
Change-Id: Ia3b9cb7d06a88005321806c78f1dbcf93d4ba544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438929
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812888}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468697
Reviewed-by: John Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#323}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
diff --git a/chrome/browser/renderer_context_menu/copy_link_to_text_menu_observer.cc b/chrome/browser/renderer_context_menu/copy_link_to_text_menu_observer.cc
index 5dc9cf8..470930f 100644
--- a/chrome/browser/renderer_context_menu/copy_link_to_text_menu_observer.cc
+++ b/chrome/browser/renderer_context_menu/copy_link_to_text_menu_observer.cc
@@ -79,7 +79,8 @@
std::string url = url_.spec();
if (!selector.empty())
url += kTextFragmentUrlClassifier + selector;
- scw.WriteText(selected_text_ + base::UTF8ToUTF16("\n" + url));
+ scw.WriteText(base::UTF8ToUTF16("\"") + selected_text_ +
+ base::UTF8ToUTF16("\"\n" + url));
}
void CopyLinkToTextMenuObserver::OverrideGeneratedSelectorForTesting(
diff --git a/chrome/browser/renderer_context_menu/copy_link_to_text_menu_observer_interactive_uitest.cc b/chrome/browser/renderer_context_menu/copy_link_to_text_menu_observer_interactive_uitest.cc
index ee20311..1f2de0fc 100644
--- a/chrome/browser/renderer_context_menu/copy_link_to_text_menu_observer_interactive_uitest.cc
+++ b/chrome/browser/renderer_context_menu/copy_link_to_text_menu_observer_interactive_uitest.cc
@@ -77,9 +77,9 @@
ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread();
base::string16 text;
clipboard->ReadText(ui::ClipboardBuffer::kCopyPaste, nullptr, &text);
- EXPECT_EQ(
- base::UTF8ToUTF16("hello world\nhttp://foo.com/#:~:text=hello%20world"),
- text);
+ EXPECT_EQ(base::UTF8ToUTF16(
+ "\"hello world\"\nhttp://foo.com/#:~:text=hello%20world"),
+ text);
}
IN_PROC_BROWSER_TEST_F(CopyLinkToTextMenuObserverTest,
@@ -95,5 +95,5 @@
ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread();
base::string16 text;
clipboard->ReadText(ui::ClipboardBuffer::kCopyPaste, nullptr, &text);
- EXPECT_EQ(base::UTF8ToUTF16("hello world\nhttp://foo.com/"), text);
+ EXPECT_EQ(base::UTF8ToUTF16("\"hello world\"\nhttp://foo.com/"), text);
}
