Link to Safe Browsing help page in Safe Browsing settings.
Currently the help button is linked to the general Chrome help center.
We'd like it to be linked to the Safe Browsing help page directly. The
Safe Browsing help page was already added in go/mobilehelprecs.
To reuse more code, create an abstract class named
SafeBrowsingSettingsFragmentBase. This class handles help and menu
related logic. SecuritySettingsFragment,
StandardProtectionSettingsFragment and
EnhancedProtectionSettingsFragment inherit from this base class.
Bug: 1115758
Change-Id: I0fbe28eb21c46e6a0171ea987f1f1f5595111d4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353563
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Reviewed-by: Natalie Chouinard <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#800698}
diff --git a/chrome/browser/safe_browsing/android/BUILD.gn b/chrome/browser/safe_browsing/android/BUILD.gn
index bf5ed28..d03f6db 100644
--- a/chrome/browser/safe_browsing/android/BUILD.gn
+++ b/chrome/browser/safe_browsing/android/BUILD.gn
@@ -27,6 +27,7 @@
"java/src/org/chromium/chrome/browser/safe_browsing/settings/EnhancedProtectionSettingsFragment.java",
"java/src/org/chromium/chrome/browser/safe_browsing/settings/NoProtectionConfirmationDialog.java",
"java/src/org/chromium/chrome/browser/safe_browsing/settings/RadioButtonGroupSafeBrowsingPreference.java",
+ "java/src/org/chromium/chrome/browser/safe_browsing/settings/SafeBrowsingSettingsFragmentBase.java",
"java/src/org/chromium/chrome/browser/safe_browsing/settings/SecuritySettingsFragment.java",
"java/src/org/chromium/chrome/browser/safe_browsing/settings/StandardProtectionSettingsFragment.java",
]
@@ -34,6 +35,7 @@
":java_resources",
"//base:base_java",
"//base:jni_java",
+ "//chrome/browser/feedback/android:java",
"//chrome/browser/flags:java",
"//chrome/browser/preferences:java",
"//chrome/browser/profiles/android:java",
@@ -46,6 +48,7 @@
"//third_party/android_deps:androidx_annotation_annotation_java",
"//third_party/android_deps:androidx_fragment_fragment_java",
"//third_party/android_deps:androidx_preference_preference_java",
+ "//third_party/android_deps:androidx_vectordrawable_vectordrawable_java",
"//ui/android:ui_full_java",
]
annotation_processor_deps = [ "//base/android/jni_generator:jni_processor" ]
@@ -63,6 +66,7 @@
":java",
"//base:base_java_test_support",
"//chrome/android:chrome_java",
+ "//chrome/browser/feedback/android:java",
"//chrome/browser/flags:java",
"//chrome/browser/preferences:java",
"//chrome/browser/profiles/android:java",
@@ -91,6 +95,7 @@
"java/res/xml/standard_protection_preferences.xml",
]
deps = [
+ "//chrome/browser/feedback/android:java_resources",
"//chrome/browser/ui/android/strings:ui_strings_grd",
"//components/browser_ui/settings/android:java_resources",
]
