| commit | e9270d8a37769e99b7b3a6fbeae8f81d90b05c90 | [log] [tgz] |
|---|---|---|
| author | Tibor Goldschwendt <[email protected]> | Tue Aug 13 14:00:43 2019 |
| committer | Ben Mason <[email protected]> | Tue Aug 13 14:00:43 2019 |
| tree | c4b5472c8cc86d781042cd98d8454739b073d5b7 | |
| parent | b3c8aac7daf0f7a618dba829ca54ad541dd51066 [diff] |
Set Trichrome modules' min_sdk_vesion to android_sdk_version This will make the modules target SDK version 29 if we build with the Q SDK. [email protected] Bug: b/139271004 Change-Id: I5777893c61644f4c27292d57295553352ff0cd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751905 Reviewed-by: Ben Mason <[email protected]> Cr-Commit-Position: refs/branch-heads/3865@{#346} Cr-Branched-From: 0cdcc6158160790658d1f033d3db873603250124-refs/heads/master@{#681094}
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn index 81a2c9a..0c5467a 100644 --- a/chrome/android/BUILD.gn +++ b/chrome/android/BUILD.gn
@@ -2179,7 +2179,9 @@ if (_is_trichrome) { _bundle_name = "TrichromeChrome${invoker.bundle_suffix}" - _min_sdk_version = 28 + + # TODO(torne): make minsdk=Q once we no longer build hacky P version + _min_sdk_version = android_sdk_version _module_descs = trichrome_module_descs if (defined(invoker.is_64_bit_browser) && invoker.is_64_bit_browser) { if (build_apk_secondary_abi && invoker.include_32_bit_webview) {