| commit | ec5c7e453ee064be356fbe8705c53e157db2df3e | [log] [tgz] |
|---|---|---|
| author | Daniel Murphy <[email protected]> | Mon Oct 19 23:31:33 2020 |
| committer | Commit Bot <[email protected]> | Mon Oct 19 23:31:33 2020 |
| tree | d1963bf7b0c6817cffe085a0db4da2dda7bf1478 | |
| parent | 4239452e97e7aa3c790ea2c1bb143c59964ccad3 [diff] |
Hardcode default apps to not have protected storage. This fixes an issue I introduced in m85 here: https://chromium-review.googlesource.com/c/chromium/src/+/2181827 during our migration of all "bookmark apps" off of the extensions system and onto the WebAppProvider system. Making YouTube no longer a 'bookmark app' (and back to a hosted app) had the side effect of making its storage protected, because apparently all hosted apps have their storage protected. This change marks all potential default hosted apps as no longer receiving protected storage. The long term fix for this issue is to have the WebAppProvider system support default apps, and migrate these old hosted apps (which is a double-deprecated system) onto the WebApp platform: https://bugs.chromium.org/p/chromium/issues/detail?id=1140122 R=[email protected] (cherry picked from commit f800edbd1b50ecc13a0d3391f5f45ba9c84625be) (cherry picked from commit 954e0815dff6f929a9d7c3f251a7143ed1a5a436) Bug: 1139902 Change-Id: I0d09eed3bf232407192fd07e621b82bcac4263f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485436 Reviewed-by: Devlin <[email protected]> Reviewed-by: Chase Phillips <[email protected]> Reviewed-by: Victor Costan <[email protected]> Commit-Queue: Daniel Murphy <[email protected]> Cr-Original-Original-Commit-Position: refs/heads/master@{#818570} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485049 Reviewed-by: Krishna Govind <[email protected]> Cr-Original-Commit-Position: refs/branch-heads/4296@{#7} Cr-Original-Branched-From: 348f473375481bbae653524aad76d79cb8285fd7-refs/heads/master@{#818242} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485139 Reviewed-by: Daniel Murphy <[email protected]> Commit-Queue: Krishna Govind <[email protected]> Cr-Commit-Position: refs/branch-heads/4280@{#516} Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.