Google Git
Sign in
chromium / chromium / src / fbc9afe64e367f83682d4e5ad3fc6e019fee0f14
commitfbc9afe64e367f83682d4e5ad3fc6e019fee0f14[log] [tgz]
authorMei Liang <[email protected]>Mon Oct 12 20:10:38 2020
committerCommit Bot <[email protected]>Mon Oct 12 20:10:38 2020
tree97e492ccfb2a080f9148b1674a9ee4e38e94a4b6
parent28cb9567a682bf2368025eb0267248bcf29fedb1 [diff]
Fix TabGroupModelFilter casting exception

TabUiFeatureUtilities.isTabGroupsAndroidEnabled() does not guarantee
TabModelFilterProvider().getTabModelFilter() returns
TabGroupModelFilter. It can return null before
TabModelSelectorBase#initialize() is called. This CL early returns when
TabModelFilterProvider().getTabModelFilter() is not a
TabGroupModelFilter to avoid the casting exception.

This CL is gated by Finch parameter "enable_launch_polish" under flag
"enable-tab-grid-layout", with gate function
TabUiFeatureUtilities#isLaunchPolishEnabled.

(cherry picked from commit bdbeca365c145f292174a50a8f02c42fffa14f92)

Bug: 1133922
Change-Id: I9766d4f0f54c954f8205866aa0c514b508d7a5a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442479
Commit-Queue: Mei Liang <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812865}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466162
Reviewed-by: Mei Liang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#266}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
1 file changed
tree: 97e492ccfb2a080f9148b1674a9ee4e38e94a4b6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.