| commit | fe2702e96ce66e27b4e474f4a39eb78813de5fcc | [log] [tgz] |
|---|---|---|
| author | Brian Sheedy <[email protected]> | Fri Dec 13 21:48:20 2024 |
| committer | Chromium LUCI CQ <[email protected]> | Fri Dec 13 21:48:20 2024 |
| tree | 12e55c0b3b1d3d59243fc37507502fab27e53e0b | |
| parent | 0717db643ee1dfd322018400590bb245402b02fa [diff] [blame] |
Enable import-error check on //testing Enables the import-error pylint check on //testing. Most errors are fixed by updating the PYTHONPATH used by pylint to include the necessary directories, although some import errors are simply suppressed (most commonly for vpython-provided modules). Also takes this opportunity to add comments about where each block of non-standard imports comes from. This was already present in a number of places, but not everywhere. Bug: 353942917 Change-Id: I506d35e5a6ae56471618e6b4af57dd2ecb64dd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6092016 Commit-Queue: Brian Sheedy <[email protected]> Reviewed-by: Ben Pastene <[email protected]> Reviewed-by: Paul Semel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1396194}
diff --git a/testing/buildbot/generate_buildbot_json_unittest.py b/testing/buildbot/generate_buildbot_json_unittest.py index 81d19c5..11116acf 100755 --- a/testing/buildbot/generate_buildbot_json_unittest.py +++ b/testing/buildbot/generate_buildbot_json_unittest.py
@@ -11,8 +11,11 @@ import re import unittest +# vpython-provided modules. +from pyfakefs import fake_filesystem_unittest # pylint: disable=import-error + +# //testing/buildbot imports. import generate_buildbot_json -from pyfakefs import fake_filesystem_unittest # pylint: disable=super-with-arguments