Google Git
Sign in
chromium / chromium / src / e4c508bea103158aca30ea0f9645bb4c4766cd5f
commite4c508bea103158aca30ea0f9645bb4c4766cd5f[log] [tgz]
authorCorentin Wallez <[email protected]>Tue Apr 29 07:38:27 2025
committerChromium LUCI CQ <[email protected]>Tue Apr 29 07:38:27 2025
treee1f62e9708af3ba74f8c183e21b62ca456b77cd2
parentc143ccdbd7e61ca4e4efb0e5dda7faeed5c38bc4 [diff]
Reland "[webgl] Make WebGLObject the owner of the object's ID"

This is a reland of commit de41806ec1b526f30034f342490eca9746fea096

Reland with a fix for WebGLUnownedTexture calling SetObject(0) which
triggered an DCHECK.

Original change's description:
> [webgl] Make WebGLObject the owner of the object's ID
>
> Logic to get, set and check the GLuint ID of the WebGL object was
> duplicated between WebGLSharedPlatform3DObject and the non-shareable
> object, leading to some complexity and additional virtual calls. Merge
> all the logic in WebGLObject. This will make it easier to work with
> WebGL[Context/Shared/Shared3DPlatform]Object in future CLs.
>
> Also move IsRenderbuffer/Texture on WebGLObject and remove other unused
> RTTI virtual methods.
>
> Bug: 413078308
> Change-Id: Ie9fbd263b9958007caec0ba744ed300bf3407157
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6485690
> Reviewed-by: Brandon Jones <[email protected]>
> Commit-Queue: Corentin Wallez <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1451655}

Bug: 413078308
Change-Id: I1a69a46adec38226d9eb0ebddbfb513107d8e0be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6494369
Reviewed-by: Brandon Jones <[email protected]>
Commit-Queue: Corentin Wallez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1453102}
28 files changed
tree: e1f62e9708af3ba74f8c183e21b62ca456b77cd2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.