| commit | 5df72efed1de3c81f7590dbc09b240cb6edc4cd6 | [log] [tgz] |
|---|---|---|
| author | Fletcher Woodruff <[email protected]> | Tue Sep 15 17:50:25 2020 |
| committer | Commit Bot <[email protected]> | Thu Oct 01 01:33:25 2020 |
| tree | 81a11296fa5acade5035e76fe615e831b2cd8ca8 | |
| parent | d5ad6a50d168252d431f99cd227e327a86c567ff [diff] |
system_api: add scan dimensions to lorgnette API Add a field to the DocumentSource proto which specifies the dimensions for the input source (in millimeters). Add a field to ScanSettings which allows specifying the region to scan from. BUG=b:168826755 TEST=cq Change-Id: Iaf49591867b71b0285b39076f0cad7d11f2fe128 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2419315 Commit-Queue: Fletcher Woodruff <[email protected]> Tested-by: Fletcher Woodruff <[email protected]> Reviewed-by: Benjamin Gordon <[email protected]> Reviewed-by: Jesse Schettler <[email protected]> Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: 911fccb56a699eea34c9283bbb82cbea97814515
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.