From 239ed56f4b719179278b1983e635f8ccc32f2eb9 Mon Sep 17 00:00:00 2001 From: Ulf Hermann Date: Thu, 7 Sep 2017 13:17:32 +0200 Subject: QmlDebug: Decouple QmlDebugConnection and QmlDebugClient The protected methods of QmlDebugClient need to be called by QmlDebugConnection already. We also want to call them directly for testing, so we make them public rather than having QmlDebugConnection be a friend. By using a QPointer, we can avoid resetting the connection on each client when it is deleted. Change-Id: I2c0e3d2b8ec19e9acbc6b8f5623b4c28caae319a Reviewed-by: hjk --- src/libs/qmldebug/qmlenginecontrolclient.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/libs/qmldebug/qmlenginecontrolclient.h') diff --git a/src/libs/qmldebug/qmlenginecontrolclient.h b/src/libs/qmldebug/qmlenginecontrolclient.h index 43d2efdc80d..c947fd72f01 100644 --- a/src/libs/qmldebug/qmlenginecontrolclient.h +++ b/src/libs/qmldebug/qmlenginecontrolclient.h @@ -52,6 +52,8 @@ public: void blockEngine(int engineId); void releaseEngine(int engineId); + void messageReceived(const QByteArray &) override; + signals: void engineAboutToBeAdded(int engineId, const QString &name); void engineAdded(int engineId, const QString &name); @@ -59,7 +61,6 @@ signals: void engineRemoved(int engineId, const QString &name); protected: - void messageReceived(const QByteArray &) override; void sendCommand(CommandType command, int engineId); struct EngineState { -- cgit v1.2.3