From eaba657d90c896e45fbd2ab24276b7cc86ec5653 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Mon, 16 Nov 2020 21:58:53 +0100 Subject: Fix warnings about possible detach of temporary objects Calling first() or last() on temporary container may unnecessarily detach the container. Fix it by calling constFirst() and constLast(). Change-Id: I2460efd5dbee1534eec8a514d9bff2a947bfddf9 Reviewed-by: Tim Jenssen --- src/plugins/debugger/console/consoleview.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/plugins/debugger/console') diff --git a/src/plugins/debugger/console/consoleview.cpp b/src/plugins/debugger/console/consoleview.cpp index ad54b2d4b12..5d3fa6f6912 100644 --- a/src/plugins/debugger/console/consoleview.cpp +++ b/src/plugins/debugger/console/consoleview.cpp @@ -184,7 +184,7 @@ void ConsoleView::onRowActivated(const QModelIndex &index) return; const QFileInfo fi = m_finder.findFile(model()->data(index, ConsoleItem::FileRole).toString()) - .first().toFileInfo(); + .constFirst().toFileInfo(); if (fi.exists() && fi.isFile() && fi.isReadable()) { Core::EditorManager::openEditorAt(fi.canonicalFilePath(), model()->data(index, ConsoleItem::LineRole).toInt()); -- cgit v1.2.3