// Copyright (C) 2016 The Qt Company Ltd. // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0 #include "clangtoolsunittests.h" #include "clangtool.h" #include "clangtoolsdiagnostic.h" #include "clangtoolssettings.h" #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include using namespace CppEditor; using namespace ProjectExplorer; using namespace Utils; Q_DECLARE_METATYPE(CppEditor::ClangDiagnosticConfig) namespace ClangTools { namespace Internal { void ClangToolsUnitTests::initTestCase() { m_kit = findOr(KitManager::kits(), nullptr, [](Kit *k) { if (!k->isValid()) return false; if (!QtSupport::QtKitAspect::qtVersion(k)) return false; const Toolchain * const toolchain = ToolchainKitAspect::cxxToolchain(k); if (!toolchain) return false; // Wo observe clazy failures with x86/32bit MSVC kits. if (toolchain->typeId() == ProjectExplorer::Constants::MSVC_TOOLCHAIN_TYPEID && toolchain->targetAbi().architecture() == Abi::X86Architecture && toolchain->targetAbi().wordWidth() != Abi::hostAbi().wordWidth()) { return false; } return true; }); if (!m_kit) QSKIP("This test requires at least one valid kit with a valid Qt and a suitable toolchain."); if (!Core::ICore::clangExecutable(CLANG_BINDIR)) QSKIP("No clang suitable for analyzing found"); m_tmpDir = new Tests::TemporaryCopiedDir(":/clangtools/unit-tests"); QVERIFY(m_tmpDir->isValid()); } void ClangToolsUnitTests::cleanupTestCase() { delete m_tmpDir; } static ClangDiagnosticConfig configFor(const QString &tidyChecks, const QString &clazyChecks) { ClangDiagnosticConfig config; config.setId("Test.MyTestConfig"); config.setDisplayName("Test"); config.setIsReadOnly(true); config.setClangOptions(QStringList{QStringLiteral("-Wno-everything")}); config.setClangTidyMode(ClangDiagnosticConfig::TidyMode::UseCustomChecks); const QString theTidyChecks = tidyChecks.isEmpty() ? tidyChecks : "-*," + tidyChecks; config.setChecks(ClangToolType::Tidy, theTidyChecks); config.setChecks(ClangToolType::Clazy, clazyChecks); return config; } void ClangToolsUnitTests::testProject() { QFETCH(FilePath, projectFilePath); QFETCH(int, expectedDiagCountClangTidy); QFETCH(int, expectedDiagCountClazy); QFETCH(ClangDiagnosticConfig, diagnosticConfig); if (projectFilePath.contains("mingw")) { const auto toolchain = ToolchainKitAspect::cxxToolchain(m_kit); if (toolchain->typeId() != ProjectExplorer::Constants::MINGW_TOOLCHAIN_TYPEID) QSKIP("This test is mingw specific, does not run for other toolchains"); } // Open project Tests::ProjectOpenerAndCloser projectManager; QVERIFY(projectManager.open(projectFilePath, true, m_kit)); // Run tools for (ClangTool * const tool : {ClangTidyTool::instance(), ClazyTool::instance()}) { tool->startTool(ClangTool::FileSelectionType::AllFiles, ClangToolsSettings::instance()->runSettings(), diagnosticConfig); QSignalSpy waitForFinishedTool(tool, &ClangTool::finished); QVERIFY(waitForFinishedTool.wait(m_timeout)); // Check for errors const QString errorText = waitForFinishedTool.takeFirst().constFirst().toString(); const bool finishedSuccessfully = errorText.isEmpty(); if (!finishedSuccessfully) qWarning("Error: %s", qPrintable(errorText)); QVERIFY(finishedSuccessfully); QCOMPARE(tool->diagnostics().count(), tool == ClangTidyTool::instance() ? expectedDiagCountClangTidy : expectedDiagCountClazy); } } void ClangToolsUnitTests::testProject_data() { QTest::addColumn("projectFilePath"); QTest::addColumn("expectedDiagCountClangTidy"); QTest::addColumn("expectedDiagCountClazy"); QTest::addColumn("diagnosticConfig"); // Test simple C++ project. ClangDiagnosticConfig config = configFor("modernize-use-nullptr", QString()); addTestRow("simple/simple.qbs", 1, 0, config); addTestRow("simple/simple.pro", 1, 0, config); // Test simple Qt project. config = configFor("readability-static-accessed-through-instance", QString()); addTestRow("qt-widgets-app/qt-widgets-app.qbs", 1, 0, config); addTestRow("qt-widgets-app/qt-widgets-app.pro", 1, 0, config); // Test that libraries can be analyzed. config = configFor(QString(), QString()); addTestRow("simple-library/simple-library.qbs", 0, 0, config); addTestRow("simple-library/simple-library.pro", 0, 0, config); // Test that standard headers can be parsed. addTestRow("stdc++11-includes/stdc++11-includes.qbs", 0, 0, config); addTestRow("stdc++11-includes/stdc++11-includes.pro", 0, 0, config); // Test that qt essential headers can be parsed. addTestRow("qt-essential-includes/qt-essential-includes.qbs", 0, 0, config); addTestRow("qt-essential-includes/qt-essential-includes.pro", 0, 0, config); // Test that mingw includes can be parsed. addTestRow("mingw-includes/mingw-includes.qbs", 0, 0, config); addTestRow("mingw-includes/mingw-includes.pro", 0, 0, config); // Test that tidy and clazy diagnostics are emitted for the same project. addTestRow("clangtidy_clazy/clangtidy_clazy.pro", 1, 1, configFor("misc-unconventional-assign-operator", "qgetenv")); } void ClangToolsUnitTests::addTestRow(const QByteArray &relativeFilePath, int expectedDiagCountClangTidy, int expectedDiagCountClazy, const ClangDiagnosticConfig &diagnosticConfig) { const FilePath absoluteFilePath = m_tmpDir->absolutePath(QString::fromUtf8(relativeFilePath)); const QString fileName = absoluteFilePath.fileName(); QTest::newRow(fileName.toUtf8().constData()) << absoluteFilePath << expectedDiagCountClangTidy << expectedDiagCountClazy << diagnosticConfig; } int ClangToolsUnitTests::getTimeout() { const int t = qtcEnvironmentVariableIntValue("QTC_CLANGTOOLS_TEST_TIMEOUT"); return t > 0 ? t : 480000; } } // namespace Internal } // namespace ClangTools